Skip to content

Count follower milestones from the profile's follower count - #61

Merged
Mistium merged 1 commit into
mainfrom
follower-milestone-count
Oct 18, 2026
Merged

Mistium merged 1 commit into
mainfrom
follower-milestone-count

Conversation

@Mistium

@Mistium Mistium commented Oct 18, 2026

Copy link
Copy Markdown
Member

Follower milestones used the length of the public followers list. That list leaves out private accounts, so Mist's "You reached 25 followers" fired while the real count is 97.

syncFollowerMilestones now reads followers from the Rotur profile (/users/<name>) and links the notification to the profile. When a profile hides its counts, it records nothing.

It works with today's Rotur API, so it can ship any time. One side effect: Mist's stored baseline is 25, so the first check after deploy sends one catch-up "You reached 50 followers". Other accounts with private followers may get one catch-up notification too.

osl test like-milestones.test.osl passes against a fake Rotur server (97 followers, 25 of them public), and the new cases fail on the old code. The OSL type check of main.osl is clean.

The "Most followed" leaderboard already used true counts, so it's unchanged. Nothing visible changes apart from the notification's number and link.

The public list leaves out private accounts, so its length undercounts:
mist was told they reached 25 followers with 97. The milestone now links
to the profile, since follower lists are going away.
@Mistium
Mistium merged commit 2de2875 into main Oct 18, 2026
@Mistium Mistium mentioned this pull request Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant