Repository navigation
Count follower milestones from the profile's follower count - #61
Merged
Merged
Conversation
The public list leaves out private accounts, so its length undercounts: mist was told they reached 25 followers with 97. The milestone now links to the profile, since follower lists are going away.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follower milestones used the length of the public followers list. That list leaves out private accounts, so Mist's "You reached 25 followers" fired while the real count is 97.
syncFollowerMilestonesnow readsfollowersfrom the Rotur profile (/users/<name>) and links the notification to the profile. When a profile hides its counts, it records nothing.It works with today's Rotur API, so it can ship any time. One side effect: Mist's stored baseline is 25, so the first check after deploy sends one catch-up "You reached 50 followers". Other accounts with private followers may get one catch-up notification too.
osl test like-milestones.test.oslpasses against a fake Rotur server (97 followers, 25 of them public), and the new cases fail on the old code. The OSL type check ofmain.oslis clean.The "Most followed" leaderboard already used true counts, so it's unchanged. Nothing visible changes apart from the notification's number and link.