Repository navigation
Conversation
Projects that use an extension known to connect players (CloudLink, WebSocket, OriginChats, Rotur and others from the galleries, plus any extension an admin flags) now need chat details before they can be shared: a public contact for chat and acceptance of the chat rules. Undeclared projects are left out of every list until the creator adds them, without unsharing anyone's work, and the owner is told why. Players can report chat in a project; everyday reports reach the creator as well as moderators, while sexual, violent and urgent ones stay with moderators. Class accounts can't open other people's projects that connect players. Also fixes extension records and the URL blocklist never saving their appended entries.
- Detect connecting extensions by their extension ID as well as the gallery URL, and normalise gallery URLs before matching. - Accept chat reports only for projects that let players talk and that the reporter can see, skip owner notifications from blocked, muted or shadow banned reporters, send at most one per reporter and project every six hours, and leave the text out for minor and class owners. - Keep class accounts from remixing or seeing inside other people's connecting projects. - Notify each owner once per project, reindex under the project lock, cache admin flags instead of reading the extension policy on every request, and cover the admin index, merge and restore paths. - Keep chat report evidence while chat reports are open, filter space list summaries, and treat undeclared projects as unlisted in activity. - Hide custom extension URLs from viewers who can't edit the project.
- Keep chat notification markers in their own collection, so project diagnostics never prune or show them. - Only the owner can take responsibility for chat, and minor accounts can only give an https link as their public contact. - Take the history lock as well as the upload lock when saving chat details or reindexing, so a concurrent upload can't be reverted. - Resolve parent segments in gallery URLs. - Refuse classroom starter projects that let players talk.
Member
Author
|
Closing alongside MistWarp/scratch-gui#147: the player named in a chat report becomes the report subject and is sent to Rotur automatically with no evidence. Will reopen once that's fixed. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the creator of a project that lets players talk to each other responsible for that chat. MistWarp can't see or police chat that runs through other services (CloudLink, WebSocket extensions, OriginChats, Rotur and others), so the leverage is on the project itself.
What changes
POST /v1/admin/extensions/connects-players. Extension IDs are now stored onproject.extensions[].idat upload.PUT /v1/projects/:id/player-contactlets the owner add a public contact for chat and accept the chat rules (playerContactTermsVersion = 1). Only the owner can declare, minor accounts can only give an https link, and class accounts can't declare. Transferring a project clears the declaration.400 player_contact_requireduntil the project is declared.playerContactMissingon the index entry, filtered alongside shadow bans; the author and admins still see them). Owners get aplayer_contact_needednotification, at most once per project and owner. This is sent after an upload, a merge, an admin index, a moderator restore, an admin flag or an ownership transfer, and once at startup by a migration.chaton projects that let players talk, with an optional player name. Spam, harassment, hate, scam and other also notify the owner asplayer_chat_report. That notification never names the reporter, and it is skipped for reporters the owner blocked or muted, for blocked or shadow-banned reporters, and after the first one per reporter and project in six hours. Owners who are minors or class accounts don't get the text. Sexual, violent and urgent reports stay with moderators. A named player becomes the report subject, so Rotur can act on that account, and the snapshot says the name wasn't checked.GET /v1/projects/:idgainsplayerContact(connects,services,declared,contact,required,missing, ...). Custom extension URLs are only shown to editors.Also fixed
OSL copies arrays on
assert, sostoreProjectExtensionsnever saved the URLs and project lists of extension records, and blocking an extension URL never saved either. Both now write the array back.Decisions for you
playerContactTermsVersionin both repos if you change them./blobs/projects/:id/project.jsonstays public for shared projects. Anyone signed out can play them anyway, so the class-account block is account-level, not a sandbox.Testing
osl lsp check main.oslis clean, every*.test.oslpasses with no warnings, andosl compilebuilds. There are new tests inplayer-contact-policy.test.oslandbanned-owners.test.osl.No visible surface in this repo; the screenshots are in the site PR.