Skip to content

DEVOPS-1129: Add zizmor security scan workflow - #72

Merged
sebhmg merged 9 commits into
developfrom
DEVOPS-1129-add-zizmor
Nov 9, 2026
Merged

sebhmg merged 9 commits into
developfrom
DEVOPS-1129-add-zizmor

Conversation

@andrewg-mira

@andrewg-mira andrewg-mira commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

DEVOPS-1129 - consolidate the 3 Zizmor workflows into a single one
Adds .github/workflows/security_scan.yml\ calling the combined
eusable-zizmor.yml\ from CI-tools v4.0.0.

surface-apps never had a zizmor scan — the merged dependabot PR #65 only bumped other CI-tools workflows. This new workflow:

  • annotates findings on pull requests
  • uploads SARIF to GitHub Advanced Security on pushes (public repos)

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

dependabot Bot and others added 5 commits October 27, 2026 10:07
Bumps the pre-commit-hooks group with 6 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [https://github.com/python-poetry/poetry](https://github.com/python-poetry/poetry) | `2.4.1` | `2.5.1` |
| [https://github.com/astral-sh/ruff-pre-commit](https://github.com/astral-sh/ruff-pre-commit) | `v0.15.20` | `0.17.2` |
| [https://github.com/pre-commit/mirrors-mypy](https://github.com/pre-commit/mirrors-mypy) | `v2.1.0` | `2.4.0` |
| [https://github.com/codingjoe/relint](https://github.com/codingjoe/relint) | `3.5.0` | `3.6.1` |
| [https://github.com/codespell-project/codespell](https://github.com/codespell-project/codespell) | `v2.4.2` | `2.4.3` |
| [https://github.com/rstcheck/rstcheck](https://github.com/rstcheck/rstcheck) | `v6.2.5` | `6.3.0` |



Updates `https://github.com/python-poetry/poetry` from 2.4.1 to 2.5.1
- [Release notes](https://github.com/python-poetry/poetry/releases)
- [Changelog](https://github.com/python-poetry/poetry/blob/main/CHANGELOG.md)
- [Commits](python-poetry/poetry@2.4.1...2.5.1)

Updates `https://github.com/astral-sh/ruff-pre-commit` from v0.15.20 to 0.17.2
- [Release notes](https://github.com/astral-sh/ruff-pre-commit/releases)
- [Commits](astral-sh/ruff-pre-commit@v0.15.20...v0.17.2)

Updates `https://github.com/pre-commit/mirrors-mypy` from v2.1.0 to 2.4.0
- [Commits](pre-commit/mirrors-mypy@v2.1.0...v2.4.0)

Updates `https://github.com/codingjoe/relint` from 3.5.0 to 3.6.1
- [Release notes](https://github.com/codingjoe/relint/releases)
- [Commits](codingjoe/relint@3.5.0...3.6.1)

Updates `https://github.com/codespell-project/codespell` from v2.4.2 to 2.4.3
- [Release notes](https://github.com/codespell-project/codespell/releases)
- [Commits](codespell-project/codespell@v2.4.2...v2.4.3)

Updates `https://github.com/rstcheck/rstcheck` from v6.2.5 to 6.3.0
- [Changelog](https://github.com/rstcheck/rstcheck/blob/main/CHANGELOG.md)
- [Commits](rstcheck/rstcheck@v6.2.5...v6.3.0)

---
updated-dependencies:
- dependency-name: https://github.com/astral-sh/ruff-pre-commit
  dependency-version: 0.17.1
  dependency-type: direct:production
  dependency-group: pre-commit-hooks
- dependency-name: https://github.com/codespell-project/codespell
  dependency-version: 2.4.3
  dependency-type: direct:production
  dependency-group: pre-commit-hooks
- dependency-name: https://github.com/codingjoe/relint
  dependency-version: 3.6.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: pre-commit-hooks
- dependency-name: https://github.com/pre-commit/mirrors-mypy
  dependency-version: 2.4.0
  dependency-type: direct:production
  dependency-group: pre-commit-hooks
- dependency-name: https://github.com/python-poetry/poetry
  dependency-version: 2.5.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: pre-commit-hooks
- dependency-name: https://github.com/rstcheck/rstcheck
  dependency-version: 6.3.0
  dependency-type: direct:production
  dependency-group: pre-commit-hooks
...

Signed-off-by: dependabot[bot] <support@github.com>
Adds the combined reusable-zizmor.yml from CI-tools v4.0.0. It annotates
findings on pull requests and uploads to GitHub Advanced Security on
pushes to public repos, replacing the three specialized zizmor
workflows.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 5, 2026 21:09
@github-actions github-actions Bot changed the title DEVOPS-1129 Add zizmor security scan workflow DEVOPS-1129: Add zizmor security scan workflow Nov 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified for the new Zizmor security-scan workflow.

No open issues 🎉

What changed in this PR

Adds the first Zizmor security scan to surface-apps, using the consolidated CI-tools v4.0.0 workflow following the dependency updates in #65.

Changes:

  • Runs scans on pull requests and pushes for the configured development, main, release, feature, and hotfix branches.
  • Calls the reusable workflow pinned to a commit, with permissions for scanning and security-result uploads.
  • Cancels superseded runs for the same workflow and ref.
File Description
.github/​workflows/​security_scan.yml Adds scan triggers, permissions, concurrency controls, and the pinned reusable Zizmor workflow call.

Review effort: Balanced

@sebhmg sebhmg self-assigned this Nov 9, 2026
sebhmg
sebhmg previously approved these changes Nov 9, 2026
sebhmg and others added 3 commits November 9, 2026 16:56
so that they can be processed on pre-commit.ci

Also, they were not that big.
…lop/pre-commit-hooks-41af41ef61

Bump the pre-commit-hooks group across 1 directory with 6 updates
sebhmg
sebhmg previously approved these changes Nov 9, 2026
@sebhmg
sebhmg merged commit 1c72ff0 into develop Nov 9, 2026
20 checks passed
@sebhmg
sebhmg deleted the DEVOPS-1129-add-zizmor branch November 9, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants