Skip to content

Keep control archives out of Release assets - #821

Open
ZEVIN17 wants to merge 1 commit into
MiniMax-AI:mainfrom
ZEVIN17:codex/keep-control-archives-out-of-release-assets
Open

ZEVIN17 wants to merge 1 commit into
MiniMax-AI:mainfrom
ZEVIN17:codex/keep-control-archives-out-of-release-assets

Conversation

@ZEVIN17

@ZEVIN17 ZEVIN17 commented Oct 22, 2026 •

Copy link
Copy Markdown

Part of #802.

The release publisher uploads the two control archives even though installation paths do not download them. Keep the revision-specific Linux amd64/arm64 control archives and their checksums as validated local inputs for the native catalog, GHCR image publication and Actions recovery, but omit those four files from Release uploads and the expected remote inventory. This applies to version releases and manual drafts. Other assets, including offline, Runtime, node and native installer downloads, are unchanged. The maintainer guide is updated in English and Chinese.

Size comparison

Applying this upload selection to the same v0.0.12 release asset metadata:

Before After
Release assets 35 31
Uploaded bytes 3,358,513,398 3,021,907,299

Removed: amd64 control archive 230,092,885 bytes; arm64 106,512,954 bytes; checksums 130 bytes each. Total: 336,606,099 bytes (336.6 MB / 321.0 MiB), about 10%. This is an inventory comparison against the existing release, not a rebuilt distribution or a measured upload-time improvement. Build disk use and offline archive size are unchanged.

Validation

  • Publisher suite: 41 tests passed. The new exact-inventory test failed on the baseline for both publish and draft modes; it now passes while checking retained local inputs and other downloadable payloads.
  • Distribution manifest suite: 24 tests passed, using pigz 2.8.
  • CI planner/metrics checks (make check-ci): 48 tests passed.
  • Translation freshness/example and locale-route checks: 2 passed; git diff --check passed.
  • Independent review of the full diff completed with no actionable findings.

Publication/registry calls in tests are mocked. No real release, GHCR push, full distribution rebuild, or fresh-host install was performed. The VitePress-dependent translation structure test and full repository gate were not run locally.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant