Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ACP server currently constructs
LLMClientwithout passingconfig.llm.provider, so the wrapper falls back to Anthropic even when the configuration selects OpenAI. This makes OpenAI-compatible endpoints fail throughmini-agent-acpwhile the CLI honors the same configuration.This change resolves the configured provider to
LLMProviderand passes it into the ACP client. It also adds a regression test that verifies the provider reaches the client factory.Validation
uv run pytest tests/test_acp.py -q -k 'test_acp_uses_configured_provider or test_acp_turn_executes_tool'uv run python -m compileall -q mini_agent tests/test_acp.pygit diff --checkRelated to #120
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.