Skip to content

Fix repeated leaves data-fixer transformation on Minecraft 1.13.2 - #525

Merged
SkyBlade1978 merged 1 commit into
MinecraftModDevelopmentMods:master-1.13.2from
SkyBlade1978:feature/1.13.2-idempotent-leaves-fixer
Oct 30, 2026
Merged

SkyBlade1978 merged 1 commit into
MinecraftModDevelopmentMods:master-1.13.2from
SkyBlade1978:feature/1.13.2-idempotent-leaves-fixer

Conversation

@SkyBlade1978

Copy link
Copy Markdown
Contributor

What Changed

Some Forge 1.13.2 installations already have the corrected leaves data-fixer call. Base Metals was treating that valid shape as a failed transformation during world upgrades.

  • Leave an already-correct call unchanged.
  • Keep the repair for the original broken call and allow the transformer to run again safely.
  • Still reject an unknown bytecode shape rather than silently skipping it.

Checks

Four Java 8 Nashorn/ASM regression tests cover the broken, corrected, repeated and unrecognised cases. The full release checks pass, and the repaired jar was used in the disposable Advantage world-migration tests.

No registry names, saved-world identities, recipes, configuration or generation settings change. This PR updates the source only; it does not publish a release.

@SkyBlade1978
SkyBlade1978 merged commit 459a19a into MinecraftModDevelopmentMods:master-1.13.2 Oct 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant