Repository navigation
Added specific documentation for the copy-and-update-record-expression. - #160
Conversation
|
Hi! I'm your friendly content validation bot. For this PR to be labeled as Den (@dend) Kevin Ransom (@KevinRansom) Phillip Carter (@cartermp) Dan Fernandez (@thedanfernandez) Don Syme (@dsyme) - please validate this PR. |
|
|
||
| ## Syntax | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Add a fsharp syntax identifier after the three segments.
|
I added the fsharp identifier. But it is also not present in the docs for record for instance. Is this by design or simply missing there? I could add them if wanted. |
| ## Syntax | ||
|
|
||
| ``` fsharp | ||
| { record-variable with |
There was a problem hiding this comment.
nit: record-name would be preferable to record-variable here, since that's the terminology used in things like let bindings.
I think these were just missing. Thanks for adding the identifier! LGTM aside from my nitpick about |
|
Happy to oblige. |
😄 |
|
Kevin Ransom (@KevinRansom) Phillip Carter (@cartermp) can you please confirm that you want a new page for this topic? Christian Steinert (@ChrSteinert) please also add the reference to the page in |
… and update record expression document.
|
Added it to the TOC. |
|
Christian Steinert (@ChrSteinert) lowercase "and" should be good |
| ####[Flexible Types](flexible-types-[fsharp].md) | ||
| ####[Delegates](delegates-[fsharp].md) | ||
| ####[Object Expressions](object-expressions-[fsharp].md) | ||
| ####[Copy and Update Record Expressions](copy-and-update-record-expression-[fsharp].md) |
There was a problem hiding this comment.
Nit - can you rename to Copy and Update Record Expressions, so it's in its plural form, just like other docs that cover expressions?
|
Good catch. Now it's more in line with the rest. Unfortunately some are still singular, like the try-with-expression(s). Something for the future? ;) |
|
Cool, LGTM. Thanks Christian Steinert (@ChrSteinert) 🏆 |
|
Thanks Christian Steinert (@ChrSteinert) ! |
"Fixes" #157