Skip to content
This repository was archived by the owner on Nov 26, 2024. It is now read-only.

Added specific documentation for the copy-and-update-record-expression. - #160

Merged
Orca (orcabot) merged 5 commits into
MicrosoftDocs:masterfrom
ChrSteinert:master
Jun 7, 2016
Merged

Orca (orcabot) merged 5 commits into
MicrosoftDocs:masterfrom
ChrSteinert:master

Conversation

@ChrSteinert

Copy link
Copy Markdown
Contributor

"Fixes" #157

@orcabot

Copy link
Copy Markdown
Contributor

Hi! I'm your friendly content validation bot. For this PR to be labeled as ready-to-merge, you'll need at least 2 comments from our designated community approvers containing the magic phrase LGTM (Looks good to me also works, for those of us that are really verbose).

Den (@dend) Kevin Ransom (@KevinRansom) Phillip Carter (@cartermp) Dan Fernandez (@thedanfernandez) Don Syme (@dsyme) - please validate this PR.


## Syntax

```

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a fsharp syntax identifier after the three segments.

@ChrSteinert

Copy link
Copy Markdown
Contributor Author

I added the fsharp identifier. But it is also not present in the docs for record for instance. Is this by design or simply missing there? I could add them if wanted.

## Syntax

``` fsharp
{ record-variable with

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: record-name would be preferable to record-variable here, since that's the terminology used in things like let bindings.

@cartermp

Copy link
Copy Markdown
Contributor

I added the fsharp identifier. But it is also not present in the docs for record for instance. Is this by design or simply missing there? I could add them if wanted.

I think these were just missing. Thanks for adding the identifier!

LGTM aside from my nitpick about record-name vs record-variable.

@ChrSteinert

Copy link
Copy Markdown
Contributor Author

Happy to oblige.
I'm quite sad that I missed the opportunity to have an oxford comma myself :P

@cartermp

Copy link
Copy Markdown
Contributor

I'm quite sad that I missed the opportunity to have an oxford comma myself :P

😄

@dend

Copy link
Copy Markdown
Contributor

Kevin Ransom (@KevinRansom) Phillip Carter (@cartermp) can you please confirm that you want a new page for this topic?

Christian Steinert (@ChrSteinert) please also add the reference to the page in TOC.md so that it displays in the table of contents.

@ChrSteinert

Copy link
Copy Markdown
Contributor Author

Added it to the TOC.
How is it supposed to be written there? Capital "And" or "and" ?

@dend

Copy link
Copy Markdown
Contributor

Christian Steinert (@ChrSteinert) lowercase "and" should be good

Comment thread docs/conceptual/TOC.md Outdated
####[Flexible Types](flexible-types-[fsharp].md)
####[Delegates](delegates-[fsharp].md)
####[Object Expressions](object-expressions-[fsharp].md)
####[Copy and Update Record Expressions](copy-and-update-record-expression-[fsharp].md)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit - can you rename to Copy and Update Record Expressions, so it's in its plural form, just like other docs that cover expressions?

@ChrSteinert

Copy link
Copy Markdown
Contributor Author

Good catch. Now it's more in line with the rest. Unfortunately some are still singular, like the try-with-expression(s). Something for the future? ;)

@dend

Copy link
Copy Markdown
Contributor

Cool, LGTM. Thanks Christian Steinert (@ChrSteinert) 🏆

@orcabot
Orca (orcabot) merged commit f8f0058 into MicrosoftDocs:master Jun 7, 2016
@cartermp

Copy link
Copy Markdown
Contributor

Thanks Christian Steinert (@ChrSteinert) !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants