Skip to content
This repository was archived by the owner on Nov 26, 2024. It is now read-only.
This repository was archived by the owner on Nov 26, 2024. It is now read-only.

Workflow question -  #115

Open
Open

Description

Just a general comment - Is there a reason the workflow is "submit a PR against live", and then live gets merged into master? It would be much easier to do it the other way around.

This actually creates extra steps for people submitting pull requests. By default, GitHub will setup a PR against master, even if you write changes against live. Having the workflow the way it is causes extra steps (that are easy to miss) when doing pull requests.

Activity

  1. dend commented on May 31, 2016

    @dend
    Contributor

    Master is the experimental branch for us currently, where everything resides. live is the branch that fetches public content that is live on MSDN. You could issue PRs against master, but that means we will still have to propagate changes to live to make sure that those are public.

  2. self-assigned this
    on May 31, 2016
  3. smoothdeveloper commented on Jun 30, 2016

    @smoothdeveloper
    Contributor

    Could we somehow setup the default branch in github to live?

    I think this will fix the issue of master being picked by default when submitting a PR (which is what I mistakenly did on #195).

  4. ReedCopsey commented on Jun 30, 2016

    @ReedCopsey
    ContributorAuthor

    Client programs will always default to master - so if you use github for windows, sourcetree, etc - you'll get master.

  5. dend commented on Jul 1, 2016

    @dend
    Contributor

    At the end of the day, it's not a big deal - I do cross-syncs for both branches, so your content will go to live regardless of where you submit it. The general guideline is just to make sure that your content is in production faster 😄

  6. removed their assignment
    on May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions