Repository navigation
Conversation
PR cabaletta#5058 sourced ServerLevelStub's RegistryAccess from client.level so that modded loot tables would resolve. However, loot tables are populated only by the ReloadableServerRegistries reload performed in load(); a client RegistryAccess never receives them. In game (client.level != null) every loot table lookup therefore threw, and the catch (Throwable) widened by that same PR silently swallowed it, leaving an empty drops list. The visible effect was that #mine stopped picking up items entirely. Revert that half so drops resolve again. The widened catch is kept, so modded blocks whose tables are absent degrade to no known drops instead of crashing, which preserves what cabaletta#5058 set out to fix. Reported-by: ZacSharp Co-Authored-By: Claude <noreply@anthropic.com>
The 26.1 and 26.2 branches both carried mod_version 1.18.0, which would collide on the v1.18.0 tag and produce identical artifact names for two distinct builds. 26.1 keeps 1.18.0; 26.2 moves to 1.19.0, matching the one-version-per-branch scheme used by every previous release. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of the fork to Minecraft 26.3.
Built the same way as the other version branches: cabaletta/baritone's
26.3branch (which has the 26.3 fixes from cabaletta#5130) with theMeteor changescommit on top. The only conflict wasmod_version, which is now26.3-SNAPSHOT.There's no
26.3branch here yet, so this targets26.2, but it shouldn't be merged into it. It would be best to create a26.3branch from this PR's head, or to retarget the PR once that branch exists.Tested on 26.3 together with Meteor: it loads into a singleplayer world with no mixin errors, and the world cache initializes.