Repository navigation
chore: update knip to latest version - #9304
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning MetaMask internal reviewing guidelines:
Ignoring alerts on:
|
|
@SocketSecurity ignore npm/@emnapi/runtime@1.11.1 The "obfuscated code" being highlighted here was a minified bundle, which isn't being used/imported in this case. The dashboard is highlighting use of eval, which is definitely questionable. But when I looked into it, it was just being used to get a reference to global |
|
@SocketSecurity ignore npm/@emnapi/core@1.11.0 The alert warns that this could be used for arbitrary code execution, but it appears that that's the entire purpose of this library |
|
@SocketSecurity ignore npm/@oxc-resolver/binding-wasm32-wasi@11.21.3 Sadly I don't have time right now to audit the WASM bundle, as this AI signal alert suggests. |
The minimum age gate has been overridden because there was a bug fixed this past weekend that resolves an issue with another PR of mine (#9395). This is an in-range update, no breaking changes.
These were missed by knip until v6.17.0
|
@SocketSecurity ignore npm/@emnapi/core@1.11.1 Same deal as with v1.11.0. It's unfortunate that the |
Explanation
The minimum age gate has been overridden because there was a bug fixed this past weekend that resolves an issue with another PR of mine (#9395).
This is an in-range update, no "breaking" changes. Though some changes were required because
knip@6.17.0fixed a mistake where undeclared sibling workspace dependencies were missed. Any missing dependencies fromcoreitself have been ignored in the config file for now.References
Includes a bug fix for a bug encountered in #9395
Checklist
Note
Low Risk
Tooling-only dependency bump and knip config allowlists; no production controller logic changes.
Overview
Bumps root knip from
^6.15.0to^6.23.0(lockfile pulls neweroxc-parser/oxc-resolverand related native bindings used by knip).Extends
knip.config.tssoyarn lint:dependenciesstill passes after knip 6.17+ starts reporting sibling workspace packages that are imported (often type-only) but not declared in each package’spackage.json. New or expandedignoreDependenciessnapshots coverperps-controller,account-tree-controller,bridge-status-controller,eip-5792-middleware, a newkeyring-controllerentry,profile-sync-controller, andtransaction-controller.These ignores are documented as temporary until teams add direct deps or confirm false positives—no runtime package code changes in this PR.
Reviewed by Cursor Bugbot for commit f00c15e. Bugbot is set up for automated code reviews on this repo. Configure here.