Skip to content

fix(registry): reconcile Seed Loom identity and restore QA runs - #19

Merged
qt314wink merged 2 commits into
mainfrom
fix/seed-loom-transfer-registry-20261102
Nov 3, 2026
Merged

qt314wink merged 2 commits into
mainfrom
fix/seed-loom-transfer-registry-20261102

Conversation

@qt314wink

@qt314wink qt314wink commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Problem and change

The bounded registry still points at the old Seed Loom owner after transfer. Use MelodicBloom/seed-loom, preserve the repository ID and historical observation in a separate provenance record, and update the schema-negative fixture. No deployment health or permission change is inferred.

Control Plane QA is configured as a required push workflow but declared no push event; GitHub recorded failures with zero jobs, including run 41554271874. Add a push trigger and keep the existing literal always() safety assertion from being interpolated by GitHub Actions. Existing safety checks and receipt upload remain in place.

Validation

  • npm ci --ignore-scripts --no-audit --no-fund, npm run test:registry, and npm run validate:registry passed locally; four existing deployment-unknown warnings remain.
  • Workflow YAML parses locally and its literal assertion matches the intended reusable workflow. Hosted run is required to validate Actions behavior.
  • The authority-vocabulary PR feat(registry): Phase 2 bounded canonical delegation vocabulary (REG-AUTH-01..06) #18 overlaps the expected-name list and fixtures; reconcile it after this change.

Summary by CodeRabbit

  • Chores
    • Quality checks now run on every push, in addition to pull requests and manual runs.
    • Improved consistency checks for workflow safety settings.
  • Documentation
    • Updated Seed Loom’s repository details to reflect its current name and owner, while preserving historical observation information.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The pull request adds push runs to the Control Plane QA workflow and updates its safety-invariant check. It also changes Seed Loom’s recorded repository identity across the registry, validator expectation, fixture, and repository documentation.

Changes: Control Plane QA workflow

Layer / File(s) Summary
Workflow trigger and safety check
.github/workflows/control-plane-qa.yml
The workflow now runs on pushes. Its safety-invariant check uses an escaped pattern to search for the literal if: ${{ always() }} expression.

Seed Loom repository identity

Layer / File(s) Summary
Registry identity reconciliation
repositories/registry.yml, scripts/automation/validate-repository-registry.mjs, tests/fixtures/registry/invalid-schema-passes-hand-checks.json, docs/repositories/CODEX_HANDOFF.md, docs/repositories/SEED_LOOM_TRANSFER_2026-11-02.md
The registry entry, validator expectation, fixture, and handoff document now use MelodicBloom/seed-loom. The reconciliation note records the former name, repository ID, and historical snapshot context.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related issues

  • MelodicBloom/.github#5 — The pull request updates the canonical registry, validator expectation, fixture, and repository documentation included in the issue’s scope. It does not complete the full requested scope.

Possibly related PRs

  • MelodicBloom/.github#17 — This pull request updates the expected repository list and fixture, and restores push runs for the QA workflow introduced in PR #17.
  • MelodicBloom/.github#14 — This pull request reconciles the Seed Loom identity in the registry and supporting validation and documentation introduced in PR #14.
Merge Risk: Minimal · up to f8d10

No concrete merge-blocking risk was identified. A hosted Actions run remains appropriate as normal validation.

Architecture risk: Low · up to f8d10

The change affects 4 systems.

Changed systems: docs, repositories, scripts, tests

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — docs (service) was modified; 2 changed files map to changed impact.
  • observed — repositories (service) was modified; 1 changed file maps to changed impact.
  • observed — scripts (service) was modified; 1 changed file maps to changed impact.
  • observed — tests (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in docs/repositories/CODEX_HANDOFF.md: The sixth repository entry now uses MelodicBloom/seed-loom and records its former qt314wink/seed-loom name and GitHub repository ID 1295858033.
  • observed — Modified behavior in docs/repositories/SEED_LOOM_TRANSFER_2026-11-02.md: Adds a repository-transfer reconciliation note with the current and prior repository names, ID, registry address status, historical snapshot date and context, evidence references, and limits on what the transfer establishes.
  • observed — Modified behavior in repositories/registry.yml: The Seed Loom registry entry changes its repository identity from qt314wink/seed-loom to MelodicBloom/seed-loom, changes the owner from qt314wink to MelodicBloom, updates the repository and commit URLs, and revises the upstream-sync description. Its other recorded values are unchanged.
  • observed — Modified behavior in scripts/automation/validate-repository-registry.mjs: The expected repository entry changes from qt314wink/seed-loom to MelodicBloom/seed-loom.
Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes both primary changes: reconciling the Seed Loom registry identity and restoring QA runs.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (5 skipped: 5 unsupported.)

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cc394ed5-20c6-477e-9ea9-ab63e5cc7549
Commits

Reviewing files that changed from the base of the PR and between c3f7d7f and f8d103d.

Files selected for processing: 6
  • .github/workflows/control-plane-qa.yml
  • docs/repositories/CODEX_HANDOFF.md
  • docs/repositories/SEED_LOOM_TRANSFER_2026-11-02.md
  • repositories/registry.yml
  • scripts/automation/validate-repository-registry.mjs
  • tests/fixtures/registry/invalid-schema-passes-hand-checks.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

@qt314wink qt314wink changed the title fix(registry): reconcile Seed Loom transfer identity fix(registry): reconcile Seed Loom identity and restore QA runs Nov 3, 2026
@qt314wink
qt314wink marked this pull request as ready for review November 3, 2026 00:43
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T00:44:54.633639Z f8d103d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@qt314wink
qt314wink merged commit 30ff982 into main Nov 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant