You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, congrats for the tool. It seems really promising!
I've been trying to run handle_http example, I get status: READY (everything goes fine, apparently) but get a 500 when I enter the resulting url. When I log to google cloud error reporting I got this error:
ImportError: No module named urlparse Failed to execute script function
at _import_module (site-packages/six.py:82)
at _resolve (site-packages/six.py:160)
at __get__ (site-packages/six.py:92)
at <module> (site-packages/cloudfn/http.py:5)
at load_module (/tmp/pip-build-QIE5nA/pyinstaller/PyInstaller/loader/pyimod03_importers.py:389)
at <module> (function.py:1)
My steps are:
1/ create files function.py, deploy.sh and requirements.txt
2/ create new virtualenv and install requirements
3/ launch deploy
I checked on the python console if I can import urlparse, or six.moves.urlib.parse and everything seems fine. I am running everything on python 2.7.
@jmderueda I can't see your full trace, but might be the same issue I am having - my trace after deployed and tested is:
File "http_test.py", line 1, in
File "/tmp/pip-build-1Vm687/pyinstaller/PyInstaller/loader/pyimod03_importers.py", line 389, in load_module
File "site-packages/cloudfn/http.py", line 5, in
File "site-packages/six.py", line 92, in get
File "site-packages/six.py", line 160, in _resolve
File "site-packages/six.py", line 82, in _import_module
ImportError: No module named urlparse
I think it's an issue with using urlparse (from six) vs urlparse (built-in python). Both urlparse return the same object so I think we can use python's built-in safely.
@MartinSahlen maybe we can test this this change in http.py? Let me know if you're OK I can send another pull request for this change (I wasn't able to test because when deployed, requirements.txt
does not seem to like git+git://xxxxx@branch)
[edit] the fix will only work for python 2, with python 3 we would need a couple of more lines. If this is the issue, I will add to the fix.
On Thu, Sep 28, 2017 at 1:21 AM, marcelopham ***@***.***> wrote:
@jmderueda <https://github.com/jmderueda> I can't see your full trace,
but might be the same issue I am having - my trace after deployed and
tested is:
File "http_test.py", line 1, in
File "/tmp/pip-build-1Vm687/pyinstaller/PyInstaller/loader/pyimod03_importers.py",
line 389, in load_module
File "site-packages/cloudfn/http.py", line 5, in
File "site-packages/six.py", line 92, in *get*
File "site-packages/six.py", line 160, in _resolve
File "site-packages/six.py", line 82, in _import_module
ImportError: No module named urlparse
I think it's an issue with using urlparse (from six) vs urlparse (built-in
python). Both urlparse return the same object so I think we can use
python's built-in safely.
@MartinSahlen <https://github.com/martinsahlen> maybe we can test this this
change in http.py
<mrmacpholea@a88e372>?
Let me know if you're OK I can send another pull request for this change (I
wasn't able to test because when deployed, requirements.txt
does not seem to like ***@***.***)
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADKgrgze8X9KUOLcFBAf7y7swrfK7Juyks5smthygaJpZM4PPuy_>
.
As far as my understanding goes, six is a compatibility layer that makes sure that code works on both python 2 and 3 where stuff is deprecated or changed? I'll look some more into this.
@MartinSahlen @marcelopham I can confirm the change in http.py of
from six.moves.urllib_parse import urlparse
to from urlparse import urlparse
change worked for me using python 2.7. Though because py-cloud-fn pulls its requirements from pip at build time, I had to manually edit the site-packages within the cloudfn directory and recompile the python .pyc file before deploying.
Activity
manurueda commentedon Sep 7, 2017
function.py
requirements.txt
pycloudfn==0.1.205deploy.sh
MartinSahlen commentedon Sep 7, 2017
Thanks, I'll have a look this weekend :D
MartinSahlen commentedon Sep 7, 2017
And please bear with me, this was created over a few jetlagged days in New York, it is very much alpha 😂
manurueda commentedon Sep 11, 2017
Other examples work pretty well 💯
mrmacpholea commentedon Sep 27, 2017
@jmderueda I can't see your full trace, but might be the same issue I am having - my trace after deployed and tested is:
I think it's an issue with using urlparse (from six) vs urlparse (built-in python). Both urlparse return the same object so I think we can use python's built-in safely.
@MartinSahlen maybe we can test this this change in http.py? Let me know if you're OK I can send another pull request for this change (I wasn't able to test because when deployed, requirements.txt
does not seem to like git+git://xxxxx@branch)
[edit] the fix will only work for python 2, with python 3 we would need a couple of more lines. If this is the issue, I will add to the fix.
Thanks
manurueda commentedon Sep 27, 2017
MartinSahlen commentedon Sep 28, 2017
Just wondering if this (not using six) will break compatibility with python2+3?
manurueda commentedon Sep 28, 2017
MartinSahlen commentedon Sep 28, 2017
As far as my understanding goes, six is a compatibility layer that makes sure that code works on both python 2 and 3 where stuff is deprecated or changed? I'll look some more into this.
mrmacpholea commentedon Sep 28, 2017
We could do something like:
davidbernat commentedon Nov 5, 2017
@MartinSahlen @marcelopham I can confirm the change in http.py of
from six.moves.urllib_parse import urlparseto
from urlparse import urlparsechange worked for me using python 2.7. Though because py-cloud-fn pulls its requirements from pip at build time, I had to manually edit the site-packages within the cloudfn directory and recompile the python .pyc file before deploying.
JulienD commentedon Jan 25, 2018
Hi,
Trying for the first time the repo and got the same error. Any progress on this topic ? I'm using Python 2.7.
What are the issues using the default urlparse lib instead of the one provided by six ?
Thanks @davidbernat, your steps description worked for me as well.
Thanks