Repository navigation
MDEV-38349 Fix assert thd->abort_on_warning == 0 in mysql_insert - #4715
Conversation
grooverdan
added
the
External Contribution
|
Thanks for the fix and clear description as to why this occurs. Can you include the test case from the MDEV to the bottom of mysql-test/main/vector_innodb.test before '--echo # End of 11.8 tests' and |
749da59 to
868cb23
Compare
868cb23 to
4ba454a
Compare
grooverdan
left a comment
grooverdan
left a comment
There was a problem hiding this comment.
Happy with this. Thanks for the quick fixes. I'm just waiting sure all of CI passes on this.
gkodinov
left a comment
gkodinov
left a comment
There was a problem hiding this comment.
Thank you for your contribution. This is a preliminary review.
LGTM. And thanks to Daniel for reviewing this.
When prepare_for_replace() fails, the code returned early via DBUG_RETURN(1), bypassing the abort label which resets thd->abort_on_warning to 0. This left the THD in a dirty state, triggering the dispatch_command assertion at end of command dispatch. Signed-off-by: Amodh Dhakal <amodhakal@gmail.com>
4ba454a to
a7ea000
Compare
|
Thank you @amodhakal ! This will be part of the next release. |
When prepare_for_replace() fails, the code returned early via DBUG_RETURN(1), bypassing the abort label which resets thd->abort_on_warning to 0. This left the THD in a dirty state, triggering the dispatch_command assertion at end of command dispatch.
Meant to fix https://jira.mariadb.org/browse/MDEV-38349