Repository navigation
Research: show the brand wordmark in the top nav - #1675
Open
maple-engineering[bot] wants to merge 1 commit into
Open
maple-engineering[bot] wants to merge 1 commit into
maple-engineering[bot] wants to merge 1 commit into
Conversation
The top nav still drew the retired lockup: the old leaf PNG beside the old MAPLE wordmark SVG, as two separate images. The brand page now supplies a single wordmark file, so the nav renders that instead. The light wordmark is the one for a dark ground, which is what the nav bar is (#111111/80), so one image replaces both. The nav is shared by the marketing and policy pages (about, proof, privacy, terms, team invite) as well as redeem, so they all show the new mark. Co-authored-by: Maple Engineering <ed24cd5651d75896f9c44c4caf0efe89abd3b86a7531feffdf6b87e3cc0bc37c@buzz-01.tail87ed4d.ts.net>
Contributor
|
Maple development preview: https://93d070e2.maple-ca8.pages.dev Commit: Uses development API, billing, flags and PCR configuration. Cloudflare Access applies. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The top-left of the redeem page (
app.maple.ai/redeem) still showed the retired lockup: the old leaf icon PNG next to the oldmaple-logo.svgwordmark, two separate images. The brand page supplies the current logo as one file, so the nav draws that single image instead.TopNavis the shared header for the marketing and policy pages too (about,proof,privacy,terms,team/invite), so they get the same new mark. Nothing else on the page is re-themed.Diff
apps/maple-research/frontend/public/maple-wordmark-light.svg: the brand page's wordmark, light variant, added as supplied.apps/maple-research/frontend/src/components/TopNav.tsx: the two<img>elements in the logoLinkbecome one<img src="/maple-wordmark-light.svg" alt="Maple">at the sameh-8height. The light variant is the one for a dark ground; the nav bar is#111111/80.maple-icon-nobg.pngis no longer referenced by the frontend; it is left inpublic/rather than deleted in this change.Validation
bun run format:check,bun run lint,bun run typecheck— pass (in the pinned Nix dev shell).bun test— 1202 pass, 0 fail across 126 files.I did not open the page in a browser, so the rendered proportions at
h-8(about 165px wide for a 247×48 wordmark) are verified by arithmetic, not by eye. Load/redeemand check the lockup against the header height.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.