Repository navigation
SDK: verify enclave release statements in Rust sessions, report-only - #1672
Draft
w3irdrobot wants to merge 3 commits into
Draft
w3irdrobot wants to merge 3 commits into
w3irdrobot wants to merge 3 commits into
Conversation
Verify signed release bundles using a local approval key, a pinned trusted root, and the expected environment and measurement tuple. Require a DSSE statement, one Rekor v2 log entry with a bound checkpoint, and one RFC 3161 timestamp. Enforce JSON and content-shape rules for statements, log entries, timestamp evidence, signatures, certificates, and media types. Add accepted and rejected managed-key corpus cases without connecting the verifier to sessions.
Observe the authenticated enclave's release after attestation and transcript checks without delaying or failing the session. Support the embedded Development bundle, bound remote lookups to 1 MiB, cache verified results, and permit one bounded TUF refresh before one retry. Expose the latest outcome through the client without observing unauthenticated loopback sessions. Cancel pending observations with the client and prevent queued cryptographic work from starting afterward.
Keep Rust formatting, Clippy, tests and documentation active while the manifest has Git-only dependencies that cannot be packaged. Emit an explicit marker for that state, restore packaging when registry versions are available, and reject missing archives otherwise. Stage and compare the approval key and trusted root through the SDK lane tests, and select that lane when either trust input changes.
w3irdrobot
force-pushed
the
codex-sigrs-maple
branch
from
November 21, 2026 14:03
34e9772 to
025c074
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
The Rust SDK now checks an enclave's signed release statement after Transport V2 session setup and logs the result. It is report-only: it never changes, delays or fails a session, and there is no UI. This is the Rust counterpart of #1668.
After a remote enclave's attestation and transcript checks pass, the SDK starts a background task that:
attestations-dev.maple.aiorattestations.maple.ai);Read this first: publishing
maple-sdkThis makes
maple-sdkunpublishable to crates.io until its Sigstore dependency comes from the registry again. Upstreamsigstore-verifycannot verify P-384 keys logged in Rekor v2, so the SDK depends on theMaplePrivacyLabs/sigstore-rustfork by Git revision, and crates.io rejects Git-only dependencies.maple-sdk5.0.0 andmaple-proxy0.5.1 for crates.io. Publish those before merging this, or hold this until they are out.maple-sdkrelease needs one of: an upstream release with the fix (feat(rekor,verify): verify P-384 Rekor v2 hashedrekord entries sigstore/sigstore-rust#375 is open for the P-384 part), or published copies of the fork's crates.cargo packagecannot run, the third commit changes thesdk-rustlane: it still runs format, Clippy, tests and docs, and it skips packaging and the upload validation while the manifest has a Git-only dependency, printing why. It does not add a registry version beside the Git source, since packaging would then ship the unpatched upstream crate. The lane therefore no longer proves that a packaged crate builds. I have not run the real publish workflow against this; I expect it to stop for lack of a crate file.How to read it
Three commits, in order:
sdk/rust/src/release_verification/bundle.rs, the trust assets, and the tests. 100 of the files are a copied test corpus undersdk/rust/tests/fixtures/managed-key/.sdk/rust/src/transport_v2/client.rs, and the lockfiles of the three in-tree consumers (proxy, Agent, Research desktop) plus the fork's hash in Agent'sflake.nix.Outside the corpus and the generated lockfiles it is about 3,000 lines.
Things worth knowing
approval-key-not-configured, makes no request and never falls back to the Dev key.sigstore-*crates, all from one fork revision, in all four lockfiles; none from the registry. The SDK and proxy lockfiles gain 61 crate names, Agent 19, Research 22.Checked
scripts/ci/opensecret-release/in the SDK lane, and a change to either selects that lane.cargo metadata --locked --offlinepasses for all four manifests. The test suites were not rerun locally after that rebase.Not checked
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.