Repository navigation
OpenSecret: move from our tinfoil-rs fork to upstream 0.3 - #1648
Draft
AnthonyRonning wants to merge 1 commit into
Draft
AnthonyRonning wants to merge 1 commit into
AnthonyRonning wants to merge 1 commit into
Conversation
Upstream tinfoil-rs now verifies V3 attestation for a named enclave, so the fork that added it is no longer needed. Pin v0.3.0-rc.2. The SDK pins a dedicated guest to one repository. The approved tag, digest and launch measurement move into a policy check that runs on every verification of that client. Only the SEV-SNP launch measurement is pinned now; a TDX guest is never approved. Every verification has a freshness deadline, the shared router's too. A verification is renewed an hour ahead of it without a request in hand, and a client that still expires is replaced as before. Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
OpenSecret pins our fork of
tinfoil-rsbecause upstream could not verify V3 attestation for a named enclave. Upstream now can (their rewritten 0.3 line), and our upstream PR was closed as superseded. This moves us onto upstream so we stop maintaining a security-critical fork.Draft until upstream tags a final
v0.3.0. This pins the release candidatev0.3.0-rc.2. Before merge: bump the tag, the twooutputHashesinflake.nix, and re-run the live tests below.What changes
tinfoilnow comes fromtinfoilsh/tinfoil-rsatv0.3.0-rc.2, without its OpenAI feature (we only use the attested HTTP client). The lockfile loses about 20 crates and gains 4.provider_client/attested.rs. Every SDK type lives here. The transport above it sees a verified client, finite failure labels and a send outcome.maple_inference.rs). The SDK pins a dedicated guest to one repository. Tag, digest and launch measurement are checked by our ownMaplePolicy, which the SDK calls on every verification of that client, including the ones it runs by itself after a key rotation. Current and staged release lists per guest work as before.configuration/network/attestation, with the verifier layer (envelope,provenance,quote,policy) orrelease_not_approvedas the reason.Behaviour changes to review
user_cache_secretin the body, and the SDK never overwrites a non-empty one. The only Tinfoil request on an eligible path without one is System One's token-table probe (/v1/completions, fixed prompts, no user data); the SDK's router client now adds a per-process random secret to it instead of sending none. The dedicated guests use an enclave client, which adds nothing; their per-usercache_saltis unchanged.atc.tinfoil.sh(router list), the routers it lists (todayrouter-0.tinfoil.shandinference.tinfoil.sh), theinference.tinfoil.shfallback, and each enclave's own host for its attestation document. All are already in the enclave's host map and forwarders. Verification is offline, so the GitHub, Sigstore TUF and KDS hosts are no longer contacted; their forwarders are left in place, and removing them is a separate deploy change.Tests
cargo fmt --check,cargo clippy --all-targets --all-features -D warnings,cargo test --all-features: 1217 passed, 107 ignored.cargo deny check advisories bans: ok. Both existing ignores still apply and their notes are updated..#default.cargoDeps) builds with the new hashes. The EIF itself was not built locally.ProviderClient, Nov 18:live_maple_guests_attest_and_complete_through_the_direct_transport(new): both guests verify against the compiled policy, then serve models, one completion and one stream.live_tinfoil_models_and_completions_match_the_legacy_api_contract: passes. Two stale assertions fixed: it hard-coded Tinfoil's model list, and gave a reasoning model 32 tokens.Not verified
Nothing here has run inside an enclave. EIF build, PCR approval and a Dev rollout are separate steps.
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.