Repository navigation
Agent: one short call for an eased hover, used everywhere - #1577
Closed
AnthonyRonning wants to merge 1 commit into
Closed
AnthonyRonning wants to merge 1 commit into
AnthonyRonning wants to merge 1 commit into
Conversation
`.hover_bg(color)` replaces `hover_background(element, rest, hover)`. It reads the resting background from the control itself, so a call site no longer restates that colour beside the `.bg(..)` that set it, and the two cannot drift. The 36 call sites shrink from a five-to-nine-line `.map` block to one line each. The nine hover backgrounds that still changed in a single frame (the Settings catalog cards and tiles, the usage chart's bars and range pills, the theme pills, the ACP example tabs, the effort reset button and two transcript controls) now ease like the rest. `motion::reveal(element, visible)` fades a control in place; the sidebar's chevron used a hover with two transparent colours to get that. No colour or timing changes. The danger button sets its own fill now instead of relying on the hover to paint it. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
Folded into #1575. The rework of the motion layer (springs and timing, the hover call, the shared composer numbers and the send fixes) is one PR now instead of four. This commit is unchanged and is on that branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fifth PR of the stack. It changes how a hover background is written, not how it looks.
What changed
One call.
.hover_bg(color)replaceshover_background(element, rest, hover). It reads the resting background from the control itself, so a call site no longer restates the colour it just set with.bg(..):All 36 call sites are converted, and the two colours can no longer drift apart.
Every hover eases. Nine hover backgrounds still changed in a single frame, most of them in Settings code that merged after the motion branch was cut: the catalog cards and tiles, the usage chart's bars and range pills, the theme pills, the ACP example tabs, the effort reset button and two transcript controls. They now ease like the rest.
motion::reveal(element, visible)fades a control in place. The sidebar's section chevron was using a hover between two transparent colours to get that.Behaviour
No colour or timing changes. Two details:
Validation
On macOS, at this head:
cargo test -p maple-agent-app --lockedwith-D warnings: 1,485 passed, 0 failed, 3 ignored, and the repository pre-commit hook passed.Not verified
A running app. The nine newly eased controls in particular have only been compiled and tested, not looked at.
🤖 Generated with Claude Code