Skip to content

Agent: add update actions beside Settings, with Retry after a failure - #1576

Open
matthewrball wants to merge 14 commits into
masterfrom
ux/update-card
Open

matthewrball wants to merge 14 commits into
masterfrom
ux/update-card

Conversation

@matthewrball

@matthewrball matthewrball commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

What this PR does

  • Replaces the persistent update card with a shortcut beside Settings, or above the gear in the collapsed sidebar.
  • The Settings menu leads with the update, above Usage: "Maple 0.0.26 is ready / Restart to install".
  • A ready update opens the existing restart confirmation from either place. Nothing restarts without it.
  • After a failure the shortcut opens the menu, whose header says "Update failed" with a Retry button. The menu stays open while it checks. The header row itself opens About for the full message.
  • A manual download opens About. "Later" in About hides both entry points until the next release.
Dark Light
Ready Ready update at the top of the Settings menu, dark Ready update at the top of the Settings menu, light
Failed Update failed with Retry, dark Update failed with Retry, light

While Retry checks · Collapsed sidebar · Restart confirmation

Notes

  • Uses the shared popup: the header is a MenuItem with custom content, and Retry is its trailing control. Retry emits the existing UpdateAction::Check; no updater changes.
  • The Settings row is one eased hover plate through hover_bg, as Agent: rework the motion layer on springs, with timing in one place #1575 asks. The chevron keeps master's animated turn in both layouts.
  • One new string, "Couldn't install { $version }", in English, Spanish, German and Korean. "Update failed", "Retry" and "Checking for updates…" are reused. The Korean strings need a native check.
  • Retry in the menu is pointer-only, like other trailing row controls. From the keyboard, Enter on the header opens About, where Retry is a button.
  • Test: update_controls_route_by_state_without_opening_settings covers the shortcut and header per state, Retry keeping the menu open, the header while checking, "Later", and Tab, Enter and Space on the shortcut without touching the composer draft.
  • Checked on macOS with Rust 1.98: just ci-lint and cargo test -p maple-agent-app --locked pass (1,510 tests). just ci passed on the commit before the Retry change; the workspace and headless lanes were not re-run after it.
  • Screenshots are from a debug build with the update state forced, offline; that override is not in this PR. "Usage unavailable" comes from the offline setup. No real install or restart was attempted.

Card text and button labels are gpui::text!, so the accessibility tree
reads them without aria_label overrides. The version title goes through
the sidebar's MessageCache instead of formatting on every render.

Later and Update failed reuse existing strings. The installed-update
branch and the no-version fallback are gone: the desktop never forwards
an installed update to the chat, and the updater always names the
version of an update it shows.
@matthewrball
matthewrball marked this pull request as ready for review November 11, 2026 22:31
@matthewrball
matthewrball marked this pull request as draft November 11, 2026 22:44
Per Mark's review, the main screen keeps the small coral badge beside
Settings. The Settings menu's update row now says which version is
ready and what a click does ("Maple 0.0.25 is ready / Restart to
install") on the shared menu row, and still opens the restart
confirmation.
Keep the main screen quiet with a small Settings dot, as Mark requested.
Reuse the menu header and existing restart confirmation, cache version
labels, and cover collapsed-menu keyboard activation.
@matthewrball matthewrball changed the title Agent: show updates as a card above Settings Agent: show update details at the top of Settings Nov 12, 2026
@matthewrball
matthewrball marked this pull request as ready for review November 12, 2026 10:53
@AnthonyRonning

Copy link
Copy Markdown
Contributor

I like the installer at the top of the panel.

Previously we all considered the dot indicator vs the download badge and we preferred the download badge.

Keep update details in Settings and open the existing confirmation from its adjacent shortcut. Use one row hover plate and give About update actions their normal card padding.

Constraint: Preserve updater state and restart confirmation
Scope-risk: narrow
Not-tested: Live installation and the Nix repository lane
@matthewrball matthewrball changed the title Agent: show update details at the top of Settings Agent: add update actions beside Settings Nov 12, 2026
Keep master's animated Settings chevron in both sidebar layouts and add the Korean update strings.
Master's buttons now return the eased-hover wrapper, so the inline Settings target matches it with a transparent plate; the row still owns the highlight. Record the Korean update strings.
The row drew its plate with a native hover, which snapped in where master eases every hover background. The row is now the eased plate, and the Settings target inside it tracks no pointer of its own.
The failed-update mark opened About, which showed the updater's message with no plain headline. It now opens the Settings menu, whose header says "Update failed" with a Retry button and stays up while the check runs. The header row still opens About.
@matthewrball matthewrball changed the title Agent: add update actions beside Settings Agent: add update actions beside Settings, with Retry after a failure Nov 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants