Repository navigation
Agent: add update actions beside Settings, with Retry after a failure - #1576
Open
matthewrball wants to merge 14 commits into
Open
matthewrball wants to merge 14 commits into
matthewrball wants to merge 14 commits into
Conversation
Card text and button labels are gpui::text!, so the accessibility tree reads them without aria_label overrides. The version title goes through the sidebar's MessageCache instead of formatting on every render. Later and Update failed reuse existing strings. The installed-update branch and the no-version fallback are gone: the desktop never forwards an installed update to the chat, and the updater always names the version of an update it shows.
matthewrball
marked this pull request as ready for review
November 11, 2026 22:31
matthewrball
marked this pull request as draft
November 11, 2026 22:44
Per Mark's review, the main screen keeps the small coral badge beside
Settings. The Settings menu's update row now says which version is
ready and what a click does ("Maple 0.0.25 is ready / Restart to
install") on the shared menu row, and still opens the restart
confirmation.
Keep the main screen quiet with a small Settings dot, as Mark requested. Reuse the menu header and existing restart confirmation, cache version labels, and cover collapsed-menu keyboard activation.
matthewrball
marked this pull request as ready for review
November 12, 2026 10:53
Contributor
|
I like the installer at the top of the panel. Previously we all considered the dot indicator vs the download badge and we preferred the download badge. |
Keep update details in Settings and open the existing confirmation from its adjacent shortcut. Use one row hover plate and give About update actions their normal card padding. Constraint: Preserve updater state and restart confirmation Scope-risk: narrow Not-tested: Live installation and the Nix repository lane
Keep master's animated Settings chevron in both sidebar layouts and add the Korean update strings.
Master's buttons now return the eased-hover wrapper, so the inline Settings target matches it with a transparent plate; the row still owns the highlight. Record the Korean update strings.
The row drew its plate with a native hover, which snapped in where master eases every hover background. The row is now the eased plate, and the Settings target inside it tracks no pointer of its own.
The failed-update mark opened About, which showed the updater's message with no plain headline. It now opens the Settings menu, whose header says "Update failed" with a Retry button and stays up while the check runs. The header row still opens About.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
While Retry checks · Collapsed sidebar · Restart confirmation
Notes
MenuItemwith custom content, and Retry is itstrailingcontrol. Retry emits the existingUpdateAction::Check; no updater changes.hover_bg, as Agent: rework the motion layer on springs, with timing in one place #1575 asks. The chevron keeps master's animated turn in both layouts.update_controls_route_by_state_without_opening_settingscovers the shortcut and header per state, Retry keeping the menu open, the header while checking, "Later", and Tab, Enter and Space on the shortcut without touching the composer draft.just ci-lintandcargo test -p maple-agent-app --lockedpass (1,510 tests).just cipassed on the commit before the Retry change; the workspace and headless lanes were not re-run after it.