Skip to content

fix(agent): Settings dialog and Usage page follow-ups - #1541

Merged
AnthonyRonning merged 2 commits into
masterfrom
codex-setfix-maple
Nov 10, 2026
Merged

AnthonyRonning merged 2 commits into
masterfrom
codex-setfix-maple

Conversation

@AnthonyRonning

@AnthonyRonning AnthonyRonning commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Follow-ups from reviewing the Settings stack (#1507, #1512, #1513) after it merged. None of these blocked the merge.

Settings dialogs

  • Application Vim stays on the dialog. The delete-account, erase, unlock-password and server dialogs now draw over the whole Settings screen, but the sidebar under them still took Vim keys. Leaving the field and pressing h, j, Enter changed the page beneath the delete-account or server dialog, and closed the erase dialog. Region moves and the filter shortcut are now ignored while a dialog is open, and a cursor parked in the sidebar moves to the dialog's own controls.
  • The erase dialog works like the deletion dialog under Vim. Its field, Cancel and erase button are Vim targets, so j, k and Enter move and act the same way in both. Before, the erase dialog had no targets at all.
  • The page behind a dialog stays still. Moving between a dialog's controls scrolled the page underneath, because the reveal anchor belongs to the page's scroll area.
  • The erase field starts empty. Cancel cleared the typed word, but a finished erase did not, so the next open showed ERASE already typed and the erase button live. The field is cleared on open.
  • A running erase keeps its dialog and its page, as a running password change already did. A Back that is refused for that reason no longer forgets the page to return to.
  • Refresh on Developer & API clears the note left by a checkout hand-off, as the old credits refresh button did.

Usage page

  • One history fetch per visit. The flag answer and the billing status each loaded the page, so every visit fetched the history, the recent requests and their reset twice. The flag now leaves the load to a status that is still on its way.
  • A failed status load does not refetch the history, unless the page has nothing to show yet.
  • The plan-reset label on the daily chart sits to the left of its line when the line is in the right half of the chart. It was cut off at the edge ("Plan credits re").
  • The remote guard test lists the four usage_* operations beside the other billing ones.

Left alone

  • Portal button for a lapsed plan. The billing server always sends is_subscribed: true, so the state does not occur.
  • Pace sentence numbers ("20,000" where the web says "20K"). The catalog comments show the full numbers are intended.
  • Time zone. The request sends the iana-time-zone name while dates use chrono::Local. They agree unless TZ overrides the system zone; a single source needs a time-zone database dependency.
  • Focus trap in dialogs. Tab can still reach fields under a dialog. The server dialog has the same gap; it wants one shared dialog primitive, not a patch per dialog.

Validation

  • New tests: dialogs_keep_application_vim_off_the_sidebar (fails with the gate removed), erase_dialog_reopens_empty_and_a_running_erase_keeps_its_page, a_visit_fetches_the_history_once.
  • The pre-commit hook passed: just ci-lint and just ci-test.
  • Checked in a running debug build against a local stack: the reset label reads in full to the left of its line.

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

AnthonyRonning and others added 2 commits November 9, 2026 20:36
Follow-ups to the Settings regroup (#1507) and the Usage page (#1512).

- Application Vim keys no longer reach the sidebar or the filter under an
  open Settings dialog. Before, leaving the field and pressing h, j, Enter
  changed the page beneath the delete-account or server dialog, and closed
  the erase dialog.
- The erase dialog opens with an empty field every time, so the erase
  button starts inert after a finished erase as well as after Cancel.
- A running erase keeps its dialog and its page, like a running password
  change, and a refused Back no longer forgets the page to return to.
- Refresh on Developer & API clears the note left by a checkout hand-off.
- A visit to Usage fetches the history once instead of twice, and a failed
  billing status load no longer refetches it.
- The plan-reset label on the daily chart moves to the left of its line
  when the line is in the right half, where it was cut off.
- The remote guard test lists the four usage operations.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
- The erase dialog's field, Cancel and erase button are Application Vim
  targets, as the deletion dialog's controls already are, so j, k and
  Enter work the same way in both.
- Moving between a dialog's controls no longer scrolls the page behind
  it: the reveal anchor belongs to the page's scroll area, which the
  dialog is not in.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@AnthonyRonning
AnthonyRonning merged commit 79315fc into master Nov 10, 2026
23 checks passed
@AnthonyRonning
AnthonyRonning deleted the codex-setfix-maple branch November 10, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant