Repository navigation
fix(agent): Settings dialog and Usage page follow-ups - #1541
Merged
Merged
Conversation
Follow-ups to the Settings regroup (#1507) and the Usage page (#1512). - Application Vim keys no longer reach the sidebar or the filter under an open Settings dialog. Before, leaving the field and pressing h, j, Enter changed the page beneath the delete-account or server dialog, and closed the erase dialog. - The erase dialog opens with an empty field every time, so the erase button starts inert after a finished erase as well as after Cancel. - A running erase keeps its dialog and its page, like a running password change, and a refused Back no longer forgets the page to return to. - Refresh on Developer & API clears the note left by a checkout hand-off. - A visit to Usage fetches the history once instead of twice, and a failed billing status load no longer refetches it. - The plan-reset label on the daily chart moves to the left of its line when the line is in the right half, where it was cut off. - The remote guard test lists the four usage operations. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
- The erase dialog's field, Cancel and erase button are Application Vim targets, as the deletion dialog's controls already are, so j, k and Enter work the same way in both. - Moving between a dialog's controls no longer scrolls the page behind it: the reveal anchor belongs to the page's scroll area, which the dialog is not in. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from reviewing the Settings stack (#1507, #1512, #1513) after it merged. None of these blocked the merge.
Settings dialogs
h,j, Enter changed the page beneath the delete-account or server dialog, and closed the erase dialog. Region moves and the filter shortcut are now ignored while a dialog is open, and a cursor parked in the sidebar moves to the dialog's own controls.j,kand Enter move and act the same way in both. Before, the erase dialog had no targets at all.Usage page
usage_*operations beside the other billing ones.Left alone
is_subscribed: true, so the state does not occur.iana-time-zonename while dates usechrono::Local. They agree unlessTZoverrides the system zone; a single source needs a time-zone database dependency.Validation
dialogs_keep_application_vim_off_the_sidebar(fails with the gate removed),erase_dialog_reopens_empty_and_a_running_erase_keeps_its_page,a_visit_fetches_the_history_once.just ci-lintandjust ci-test.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.