Skip to content

Agent: a running task breathes a grey dot instead of a coral ring - #1521

Merged
AnthonyRonning merged 8 commits into
masterfrom
ux/task-status-indicators
Nov 20, 2026
Merged

AnthonyRonning merged 8 commits into
masterfrom
ux/task-status-indicators

Conversation

@matthewrball

@matthewrball matthewrball commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

What this PR does

  • Running: a grey dot that breathes. It replaces the coral ring, which read like a radio button. On dark, a soft band also crosses the title every 4.8 s, then rests. The title keeps its normal ink. Light has no ink brighter than its text, so there the dot carries the state alone.
  • Needs your answer: an amber reply bubble in place of the coral dot, so a task waiting on you reads as a message, not as "in progress".
  • Finished, not opened yet: a clearer green dot. Failed while unseen keeps its red alert.
  • Screen readers hear the status. A row's description leads with Running, Waiting for your answer, Last run failed, or Finished, not opened yet, then its project. This covers this computer's rows and a paired computer's rows.
  • Light mode row buttons (pin, rename, menu) use the shared hover and press overlays, and a row keeps its hover fill while its menu is open.
  • Under Reduce Motion or in a background window, the dot rests full and the title stays plain.
Before (master) After
Task states, before Task states, after
One task through its states

Running → asks you something → you answer → finishes while you're elsewhere → you open it. Dark above light.

Task status flow

Notes

  • The marks that ask for you are line icons (bubble, alert) and the passive ones are dots, so they differ by shape as well as colour. The new colours are sidebar-only tokens (sidebar_running, sidebar_running_shine, sidebar_finished); status_success is unchanged elsewhere.
  • Timings are motion tokens (RUNNING_BREATH 2.4 s, RUNNING_SHINE 4.8 s), listed in docs/motion.md. morph_text gains shine_band(reach, rest); without it the shine behaves as before. While the band rests, the title paints as one plain run.
  • The shine paints the line's single layout glyph by glyph, so letters keep their kerning as the band passes.
  • Merges cleanly into master. If Agent: Fold a turn's steps under one line that times the work #1587 lands first, morph_text.rs and docs/motion.md conflict; keep this PR's side, which adds shine_band on top of the same shine.
  • New strings in English, Spanish, German and Korean: chat-task-running, chat-task-needs-you, chat-task-failed, chat-task-finished-unseen, chat-task-status-details. The German and Korean wording would benefit from a native speaker's look.
  • GIFs are rendered offscreen through gpui's Metal renderer from the real row code. The render harness isn't in the PR.
  • While a row is hovered, its action buttons cover the status mark, as on master; that's intended.
  • Light mode on a selected row: the running and finished dots sit near 2.2:1, under the 3:1 non-text guideline. The colours match the approved design. A selected row's own transcript shows the state, and screen readers hear it.

A running task showed a coral ring with a breathing dot beside its title,
and a task waiting on a question showed a coral dot. The two differed
only by shape, and the ring read as a radio button. A running task now
shows what the transcript shows while Maple thinks: a brighter band sweeps
across its title, and the words rest a step dimmer under it, in the row's
secondary ink when selected and muted ink otherwise. Coral is left to the
task that needs you. The indicator box stays, empty, on a running row, so
the title's width holds as the task moves on to its next state.

The band is morph_text's shine, carried here as the "Maple is thinking"
line's change adds it (#1587), so the two merge cleanly in either order.
It runs on the shared loop clock like the ring did, and holds still under
reduced motion and in a background window.
A row's buttons eased to the selected-row colour on hover and pressed to
the hairline colour. On a selected row under the pointer the hover chip
came out lighter than the row, a press flashed near white, and on a
hovered row a press matched the row and showed nothing. Hover and press
now ease to the shared hover overlay and a new, stronger overlay_press
over whatever the row is, so they read one and two steps past it in
either theme. The pin and overflow buttons use the same pair, and an open
overflow button holds its press fill under the pointer.

With a task's menu open, the pointer leaves the row for the menu, so the
row eased back to rest while the action strip kept its fill. The row now
holds its hover fill while its menu is open, as a project header does,
and the strip keeps covering the title behind the open button.
A task waiting on the user and a task that finished unseen both showed an
8 px dot, told apart only by colour. The waiting mark is now a small coral
dot in a soft coral halo with a solid edge; the finished mark stays a
plain green dot, so the two differ by shape too. The coral is accent_ink,
the ink the transcript's line rests in while Maple waits on you, which
holds about 3:1 on a selected light row where the brighter coral faded.

The indicator and the title's shine had no accessible name, so screen
readers heard only a row's title and project. A task row's description
now leads with its status (Running, Waiting for your answer, Last run
failed, Finished, not opened yet), then its project details, on this
computer's rows and a paired computer's alike. The description is cached
per status and details, so the shine's repaints allocate nothing for it.
English, Spanish, German and Korean.
The shine coloured its line with a text run per letter. gpui shapes a
line anew wherever the colour changes, so each letter inside the band was
shaped alone and lost its kerning against its neighbours, while letters
outside it, all one colour, kept theirs. As the band crossed, letters
moved by up to five pixels and back. The shine now paints the resting
line's single layout glyph by glyph, each in its own tint, so the words
stay where they rest and only their colour moves.
@matthewrball
matthewrball force-pushed the ux/task-status-indicators branch from ea85e9f to 1886285 Compare November 18, 2026 03:48
@matthewrball matthewrball changed the title Agent: a running task traces its row instead of showing a coral ring Agent: a running task's title shimmers instead of showing a coral ring Nov 18, 2026
A running task's title shone too softly to catch: the band was heading
ink, close to the words it crossed, and on a selected row the words rested
in secondary ink, nearly the band's colour, so a selected running row
looked idle. The band is now activity_shine, the brightest ink each
theme has (white on dark, black on light), over words that rest in muted
ink on every row, selected or not, and it passes every 1.2 s instead of
1.9 s. The band against the words goes from 1.5:1 to 2.7:1 on a selected
dark row; the band against a selected row's fill reaches 11:1 dark and
14:1 light.

The resting words of a selected running row sit below 4.5:1 (4.2:1 dark,
3.5:1 light); the band crosses them every 1.2 s, and the task itself is
open beside the sidebar.
This reverts 9fad336. The design review chose to keep the first
shine: the title rests a step dimmer (muted ink, secondary on a
selected row) while a heading-ink band crosses it every 1.9 s, the
pace of the transcript's "Maple is thinking" line. The brighter band
drew more attention than a running row should, and it dimmed a
selected running title below 4.5:1. The activity_shine token goes with
it.
…ly bubble

Design review settled on calmer status marks: running is a grey dot
that breathes, with a soft band crossing the title on dark; a task
waiting on you shows the coral reply bubble; the finished dot is a
clearer green. Running titles keep their own ink instead of dimming.
… cheap

Amber keeps the reply bubble apart from the failed alert's red. The
running timings become motion tokens, title changes swap at once
instead of morphing, and a resting band paints the title as one run.
@matthewrball matthewrball changed the title Agent: a running task's title shimmers instead of showing a coral ring Agent: a running task breathes a grey dot instead of a coral ring Nov 20, 2026
@matthewrball
matthewrball marked this pull request as ready for review November 20, 2026 06:00

@AnthonyRonning AnthonyRonning left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick sanity check of the diff and nearby code: no obvious blockers found. No local builds or tests run.

@AnthonyRonning
AnthonyRonning merged commit 29b4e5f into master Nov 20, 2026
23 checks passed
@AnthonyRonning
AnthonyRonning deleted the ux/task-status-indicators branch November 20, 2026 06:41
matthewrball added a commit that referenced this pull request Nov 20, 2026
Master gained #1521, which carries the same shine in morph_text.rs plus shine_band; keep master's copy, whose defaults leave the thinking line unchanged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants