Repository navigation
Agent: add purposeful motion across chat, composer, menus and settings - #1509
Closed
matthewrball wants to merge 28 commits into
Closed
matthewrball wants to merge 28 commits into
matthewrball wants to merge 28 commits into
Conversation
Document the motion rules in docs/motion.md. motion.rs gains the duration and easing tokens, a retargetable Tween that the hover plates and the sidebar collapse now share, Shifted (a layout-free paint offset), element-state Animated values, icon swaps and rotating chevrons.
Animated values start at rest, reverse from the value on screen, settle without asking for frames, and snap under reduced motion. A shifted element moves by whole pixels without moving its neighbors.
Menus and popovers fade in over REVEAL while settling 4 px away from the trigger: down below it, up above it, sideways for submenus, following a flipped placement. Each opening replays the entrance, closing stays immediate, and arrow-key highlight moves land at once while pointer hover still eases. Adds HoverBackground::instant and the swap_in content fade to motion.rs.
Switch knobs slide and tracks cross-fade over TOGGLE, reversing from the knob's position; checkbox fills cross-fade and the check scales in. Dialog scrims fade and cards rise 8 px over ENTER and close at once. Tooltips fade in over REVEAL after their delay.
A new screen (Chat, Settings, sign-in, gates) fades in over REVEAL; the first screen draws at once. Settings panes fade on a section change, and on/off pills and the transport segments ease their selected fill.
Task status indicators cross-fade between states, never on first draw; section chevrons rotate, project folder icons cross-fade, and the Settings menu chevron turns as the menu opens.
Rows that arrive live in the open task (the sent message, the reply, thinking, tool cards, errors, the stop notice) fade in with a 6 px rise over 180 ms, timed from view state so a row scrolled away and back never replays it. History, task switches, paging and reconnect rebuilds stay still, as do streaming appends. The send preview rises in and hands off to the real row without a second entrance; the waiting dots fade in. Disclosure chevrons rotate and opened details fade in; a tool call that finishes on screen cross-fades its status. Another task's transcript fades in when it lands, the open spinner waits 300 ms, and notices and the cards above the composer rise in.
A queued chip fades in with the shared 6 px rise when its message is queued and leaves at once when it is sent, edited away or removed.
A multi-line field whose rows change because its text changed (typing, paste, delete, newline, clearing after send, text set from code) eases its height to the new row count over resize_duration with ease-out cubic, retargeting from the height on screen. The first layout, a new wrap width (window resize, the sidebar sliding), a font change and reduced motion snap. While the box is still shorter than its text, the text is laid out for the target height and clipped, so following the cursor never scrolls on the way. Frames are requested only while the height moves. Applies to the composer, Settings additional instructions and the feedback form. The row measure now uses the text style the field paints in: gpui runs measure callbacks outside the element's style, so the composer was sized with the window's default line height and font rather than the chat reading face.
Expand and shrink ease the composer region's height between the height of its text and expanded over PANEL with ease-out cubic. A second click mid-flight turns back from the height on screen. Both ends come from bounds measured the frame before, so the box starts and lands exactly on its resting layout; the field fills the box throughout, so typed text never moves, and the transcript keeps its tail. In the empty state the heading and the privacy line fold away and fade with the composer, so the column does not jump. The maximize and minimize icons cross-fade and scale over TOGGLE, and the button names its action to assistive technology. Reduced motion switches at once, as before.
The composer's main control cross-fades between Send and Stop over TOGGLE: the fills fade and the arrow scales, while the handler, role and accessible name switch on the frame the state changes. The send fill eases between disabled and ready instead of snapping its opacity. A file joining the draft fades and rises 6 px into place over ENTER; removing one is immediate. Reduced motion settles each at once.
Keep the waiting dots' spacing now that they fade in, drop the unused Animated::enter_from, and document swap_in and the menu entrance.
A row that arrives while the transcript follows its tail opens from nothing to its height over 180 ms, so the rows above glide up instead of jumping; scrolled up, it still only fades and rises. A reply that streams meanwhile ends at its true height. The sent bubble rises in from the moment it shows, its status line only fades, and the status shares one slot with the waiting dots, so the real message takes over the bubble's place with nothing jumping. A finished tool call drops its running state at once and fades in the outcome rather than overlapping both labels.
When the empty state gives way to a conversation (the first message, opening a task) or back (New Task), the composer region glides from where it was last drawn to its new place over 200 ms instead of jumping. glide_from moves into motion.rs so the transcript's hand-off and the composer share one paint-offset primitive. Menus the keyboard opens appear at once; pointer openings keep their entrance.
Settings dropdowns open on their current choice even from a click, so the highlighted-item heuristic skipped their entrance. Use the window's last input instead: a pointer opening slides in, a keyboard opening is drawn at rest.
The message being sent and the waiting dots sit in one slot under the transcript, outside the list. When it appears, or its content grows, it now opens over 180 ms with its content pinned to the bottom, so the transcript above glides up rather than jumping. It still shrinks at once, and the row that takes its place opens from the space it leaves, so the hand-off stays still. A task switch or history load shows it at once, and reduced motion settles it immediately.
gpui replays a cached view's last paint with the opacity it was painted at, so fading the whole screen left the cached sidebar stuck at its first, nearly transparent frame after returning from Settings. swap_in now fades a cover in the background color over content that always paints at full opacity. Document the rule for cached views.
The cover was a child of the swapped element, so in a scrolled Settings pane it moved with the content and left a band uncovered. Paint it as a quad over the element's bounds after the content instead: no extra layout node, and swap_in takes any element. Note the sidebar collapse as the one safe fade over a cached view.
The empty state never drew the slot under the transcript, so the snap a blank transcript sets carried over to the first send, and its slot appeared at full height instead of opening. Clear it while the empty state shows, and test it on the whole screen. - Reconnect replays go through one method; its test drives that method instead of toggling the quiet flag by hand. - The copy button hovers with the translucent overlay it had before, so its plate suits tinted bubbles and code blocks. - Docs: dialog cards rise 8 px, notices use ENTER, and a slid element's hitbox moves with its paint.
…ns rise in When a run ended in an error, or a send failed, the slot under the transcript (the waiting dots, or the sent message and its status) vanished at once while the error grew from nothing, so the thread dropped by the slot's height and then rose again. - A run error goes through the same path as every other live row: it ends the wait and opens from the waiting row's space. - A failed send's error opens from the whole slot's height. - The question card rises in like the other cards above the composer. - Docs: covers and fades never block input; rows that replace the slot open from its height.
Choosing Custom amount under Buy credits dropped its field in at once and pushed the pay buttons down; choosing a package snapped them back. Add motion::unfold, which eases a box between nothing and its content's height over PANEL while the content fades, turns back from the height on screen, settles under reduced motion and draws nothing once folded, and use it for the field. Its top padding stands in for the card's gap, which would otherwise jump on its own.
This was referenced Nov 8, 2026
…eing cut Shrinking the expanded composer from the empty state grew the heading's folding box from nothing with its text pinned to the box's top and clipped, so "Work on anything…" showed sliced against the composer's edge for most of the transition. Fold the box as before but leave its content whole: the heading sits at the box's foot and the note at its head, both fading, so the text rides with the composer at its resting gap. The content keeps recording its height, so a fold that starts before the heading was ever measured catches up on the next frame.
matthewrball
marked this pull request as ready for review
November 8, 2026 20:19
The region under the composer eases its height while the composer shrinks back from expanded, but only the composer's own box stretched to fill it. Anything render_composer wraps the box in, such as a new task's folder picker by the prompt (#1353), stretched only while the composer was expanded, so on the first frame of shrinking the box snapped to rest and the heading and the box dropped. Stretch whatever render_composer returns for as long as the composer fills, expanded or on the way there and back, and test a new task's shrink from where it was.
This was referenced Nov 8, 2026
Collaborator
Author
|
Moved to #1515 so the branch lives in this repo. Same commits. |
AnthonyRonning
added a commit
that referenced
this pull request
Nov 11, 2026
* Agent: set the model's effort on a slider in the model chip
The model chip and the separate thinking button become one control. The
chip names the model and, in a quieter grey, its effort ("Kimi K3 High"),
and pressing it opens an effort popover:
- The level in large type, tinted by how hard the model thinks, over the
model's name. The name opens the model list, and a pick there returns
to the popover on the new model's levels. Enter does the same from the
keyboard. `/model` still opens the list on its own.
- A thick stepped slider with one stop per level the selected model
offers: Low / High / Max on GLM and Kimi, Off through Max on DeepSeek,
and so on. Drag it, click a stop, or press Left and Right. The level
under the thumb previews while dragging and saves on release.
- Reset returns to the level the runtime uses when nobody picked one
(Medium, or the nearest level the model accepts). That stop is drawn
as a ring.
- A model that does not think, and levels that are loading, saving or
unavailable (with Retry), show a status line in the slider's place.
Each level has a heat on one scale shared by every model. Heat drives
the fill, its glow and the label, so High is the same colour wherever
its stop sits. The thumb springs to its stop with a small overshoot,
lifts while held, and the dots glide to new stops after a model switch.
Frames are drawn only while something moves, and reduced motion jumps
instead of animating.
A pick made while another is saving now waits for it, and only the
latest waiting pick goes out. The popover stays open after a pick.
The level makes the chip wider than the old button. Send and the
context ring no longer shrink; when the row runs out of room, the
model's name truncates first and the level stays readable.
Menus get two hooks for content that is not rows: on_adjust, which Left
and Right call, and on_confirm, which Enter and Space call with no row
highlighted.
* Agent: keep the effort reset compatible with animated icon buttons
The reset is an icon button while it can act and a plain dimmed icon at the recommended level. Both arms now return an element of one type, so the popover still builds once icon buttons carry their own hover animation (#1509).
* Agent: give the effort slider a liquid feel and morph its changes of state
Slider, as a few springs:
- The thumb follows the pointer through a stiff spring, so a drag is
direct but smooth. It is drawn into each stop it passes as a soft notch,
and on release it settles with a jelly overshoot. It stretches along
its motion and squashes across it.
- The fill's edge is a softer spring chasing the thumb. When the thumb
runs ahead, a neck of fill thins between them. When it runs back, the
fill drains after it with a droplet at the tip.
- Dots swell as the fill flows over them. A ripple spreads from each stop
a drag crosses and from each level that lands, and the thumb blooms in
the level's colour.
- Colour flows between the stops' heats instead of stepping.
- Opening the popover, the content rises in, the thumb pops and the fill
pours to it.
- The hand cursor opens over the thumb and closes while it is held.
Text and state, after torph's TextMorph: a new MorphText element. Letters
two values share glide to their new places, leaving letters fade out,
arriving ones rise in, and width and colour ease between them. The
popover's level name and the chip's effort use it, so "High" becomes
"Extra high" by keeping its "igh". The brain gives a small pulse as a
level lands, and reset spins back as it acts.
Everything asks for frames only while it moves, and reduced motion jumps
instead.
* Agent: keep the effort slider's fill behind its thumb
The fill's edge still trails a thumb that runs ahead, but it no longer
passes it. A thumb running back takes the edge with it, so the draining
tail and its droplet are gone. The edge's spring is now close to critical
damping (stiffness 220, damping ratio 0.9), so it doesn't slosh past the thumb on
the opening pour or when the thumb settles. The fill's rounded end stays
under the thumb, and the thumb's squash stops at the track's height. On
open the thumb now settles in from slightly large (112%) instead of
popping up from small, so it covers the track from the first frame.
Changes of state:
- The popover's level name swaps at once while a drag crosses stops, and
morphs only on a pick, a key step or reset. A morph per stop garbled a
fast sweep.
- Arriving letters start fading in at 10% of a morph rather than 25%, so
the text is never blank between values.
- Reset's spin plays once, when it acts. It no longer replays every time
the popover opens.
* Agent: spark the brain and keep the slider warm at a model's top level
Arriving at the selected model's top level (Max, or High on Gemma 4) by drag, click or arrow key flashes a warm disc behind the popover's brain and bursts a ring of rays from it. While the level stays at the top, the thumb keeps a warm halo, the fill glows a little more, and the chip's effort word turns from grey to the level's colour. An opening already at the top, or a model switch onto it, shows the halo without the spark; reduced motion keeps the halo and skips the spark.
* Agent: put the models first in the model chip's panel, effort under them
Design review: Maple's users switch models more often than effort, so the chip now opens the model list with the selected model's effort slider docked under it, instead of an effort popover whose model name led to the list. A model pick closes the panel, as the plain list did, so switching models takes two clicks again; Left and Right step the effort, Up, Down and Enter pick a model. /model opens the same panel. Menu gains a footer that stays in view while the rows scroll, and loses on_confirm, which only the old popover used. ChatPopup::Effort, effort_return and the chat-effort-change-model string go with it.
* Agent: group the model panel's models, with a Popular badge
Most capable, Uncensored, then Fast & cheap, as the list was grouped before, with a Popular badge on DeepSeek Uncensored. The catalog carries no group yet, so the app keeps a table of the current model ids; a model deployed after it lists under More models, and a catalog the table knows none of shows no headers at all.
* Agent: format the model panel and slider code
* Agent: tune the effort slider's motion after a motion audit
The slider and the status line cross-fade when levels arrive, and the status line holds the slider's height, so the panel no longer jumps. A key step moves the thumb but plays no ripple, bloom, pulse, morph or spark. A drag ripples the stops it crosses and blooms once where it lets go, instead of a landing ripple, bloom and brain pulse at every stop. The brain pulses for a pointer pick or reset only, and never replays when the panel reopens. The halo fades out when the thumb leaves the top. Opening the panel, which happens on every model switch, settles the thumb without a bounce and with the fill already in place.
* Agent: draw the recommended stop as a plain dot like the others
The ring that marked the level reset returns to read as a different kind of stop. Reset still dims at that level.
* Agent: give the Popular badge contrast that reads in light mode
The brand coral on a grey pill read at under 2:1 in the light theme. The badge now sets deep coral on the soft coral container, 5.1:1 in light and 7:1 in dark, from a new accent_text token the contrast test holds to 4.5:1.
* Agent: wrap the composer chips in narrow windows instead of overlapping them
* Agent: drop the slider thumb's coloured glow at Off
* Agent: keep waiting effort picks and keyboard Retry after the shipcheck review
* Agent: send a waiting effort pick even when its cached levels were dropped
* Agent: grey Popular badge on light, coral on dark
* Agent: darken the light Popular badge so it shows on a highlighted row
* Agent: list the models flat until the catalog groups them
The model panel kept its own table of model ids to sections and its own
list of Popular models, so a model deployed after a release listed under
More models until the next one. The catalog now serves groups and badges,
and #1540 builds the sections from it; until then the panel lists the
models flat, in the catalog's order. The group headings, the Popular
badge, its theme tokens and their strings go with the table.
* Agent: start each model at the catalog's default effort
A model with no remembered level started at Medium, moved to the nearest
level it accepts, and a switch carried the previous model's level over.
Both now take the model's `default_effort` from the catalog, which follows
the model makers' recommendations (Max for Kimi K3.1 Pro, Kimi K3 and GLM
5.3, High for DeepSeek V4.1 Flash); a model the catalog gives no default it
accepts keeps the old rule. The runtime serves that level with the levels,
and Reset to recommended returns to it.
New Task remembers one model and level, and only what the user picks
there: picking a level remembers it with the model, and picking another
model starts that model at its default and forgets the level. A task's
picks, and opening a task, leave it alone, so a task's model pick no
longer becomes the default. A level picked for a task's next model waits
in the runtime for the switch, instead of riding on the account default.
* Agent: tone the effort slider down
The slider was larger than the model rows above it and glowed strongly at
the top level, so it pulled the eye from the model list. The track is
24 px instead of 36, the thumb 27 (30 held) instead of 40 (44), and the
dots 4 instead of 5; the panel's status line keeps the slider's new
height. The fill's glow, the thumb's shadows, its held glow, the bloom
where a level lands, the top level's halo and the brain's spark there are
all softer and smaller.
* Agent: return early with ? when a model switch has no level to set
---------
Co-authored-by: Anthony Ronning <101225832+AnthonyRonning@users.noreply.github.com>
AnthonyRonning
added a commit
that referenced
this pull request
Nov 11, 2026
* Agent: set the model's effort on a slider in the model chip
The model chip and the separate thinking button become one control. The
chip names the model and, in a quieter grey, its effort ("Kimi K3 High"),
and pressing it opens an effort popover:
- The level in large type, tinted by how hard the model thinks, over the
model's name. The name opens the model list, and a pick there returns
to the popover on the new model's levels. Enter does the same from the
keyboard. `/model` still opens the list on its own.
- A thick stepped slider with one stop per level the selected model
offers: Low / High / Max on GLM and Kimi, Off through Max on DeepSeek,
and so on. Drag it, click a stop, or press Left and Right. The level
under the thumb previews while dragging and saves on release.
- Reset returns to the level the runtime uses when nobody picked one
(Medium, or the nearest level the model accepts). That stop is drawn
as a ring.
- A model that does not think, and levels that are loading, saving or
unavailable (with Retry), show a status line in the slider's place.
Each level has a heat on one scale shared by every model. Heat drives
the fill, its glow and the label, so High is the same colour wherever
its stop sits. The thumb springs to its stop with a small overshoot,
lifts while held, and the dots glide to new stops after a model switch.
Frames are drawn only while something moves, and reduced motion jumps
instead of animating.
A pick made while another is saving now waits for it, and only the
latest waiting pick goes out. The popover stays open after a pick.
The level makes the chip wider than the old button. Send and the
context ring no longer shrink; when the row runs out of room, the
model's name truncates first and the level stays readable.
Menus get two hooks for content that is not rows: on_adjust, which Left
and Right call, and on_confirm, which Enter and Space call with no row
highlighted.
* Agent: keep the effort reset compatible with animated icon buttons
The reset is an icon button while it can act and a plain dimmed icon at the recommended level. Both arms now return an element of one type, so the popover still builds once icon buttons carry their own hover animation (#1509).
* Agent: give the effort slider a liquid feel and morph its changes of state
Slider, as a few springs:
- The thumb follows the pointer through a stiff spring, so a drag is
direct but smooth. It is drawn into each stop it passes as a soft notch,
and on release it settles with a jelly overshoot. It stretches along
its motion and squashes across it.
- The fill's edge is a softer spring chasing the thumb. When the thumb
runs ahead, a neck of fill thins between them. When it runs back, the
fill drains after it with a droplet at the tip.
- Dots swell as the fill flows over them. A ripple spreads from each stop
a drag crosses and from each level that lands, and the thumb blooms in
the level's colour.
- Colour flows between the stops' heats instead of stepping.
- Opening the popover, the content rises in, the thumb pops and the fill
pours to it.
- The hand cursor opens over the thumb and closes while it is held.
Text and state, after torph's TextMorph: a new MorphText element. Letters
two values share glide to their new places, leaving letters fade out,
arriving ones rise in, and width and colour ease between them. The
popover's level name and the chip's effort use it, so "High" becomes
"Extra high" by keeping its "igh". The brain gives a small pulse as a
level lands, and reset spins back as it acts.
Everything asks for frames only while it moves, and reduced motion jumps
instead.
* Agent: keep the effort slider's fill behind its thumb
The fill's edge still trails a thumb that runs ahead, but it no longer
passes it. A thumb running back takes the edge with it, so the draining
tail and its droplet are gone. The edge's spring is now close to critical
damping (stiffness 220, damping ratio 0.9), so it doesn't slosh past the thumb on
the opening pour or when the thumb settles. The fill's rounded end stays
under the thumb, and the thumb's squash stops at the track's height. On
open the thumb now settles in from slightly large (112%) instead of
popping up from small, so it covers the track from the first frame.
Changes of state:
- The popover's level name swaps at once while a drag crosses stops, and
morphs only on a pick, a key step or reset. A morph per stop garbled a
fast sweep.
- Arriving letters start fading in at 10% of a morph rather than 25%, so
the text is never blank between values.
- Reset's spin plays once, when it acts. It no longer replays every time
the popover opens.
* Agent: spark the brain and keep the slider warm at a model's top level
Arriving at the selected model's top level (Max, or High on Gemma 4) by drag, click or arrow key flashes a warm disc behind the popover's brain and bursts a ring of rays from it. While the level stays at the top, the thumb keeps a warm halo, the fill glows a little more, and the chip's effort word turns from grey to the level's colour. An opening already at the top, or a model switch onto it, shows the halo without the spark; reduced motion keeps the halo and skips the spark.
* Agent: put the models first in the model chip's panel, effort under them
Design review: Maple's users switch models more often than effort, so the chip now opens the model list with the selected model's effort slider docked under it, instead of an effort popover whose model name led to the list. A model pick closes the panel, as the plain list did, so switching models takes two clicks again; Left and Right step the effort, Up, Down and Enter pick a model. /model opens the same panel. Menu gains a footer that stays in view while the rows scroll, and loses on_confirm, which only the old popover used. ChatPopup::Effort, effort_return and the chat-effort-change-model string go with it.
* Agent: group the model panel's models, with a Popular badge
Most capable, Uncensored, then Fast & cheap, as the list was grouped before, with a Popular badge on DeepSeek Uncensored. The catalog carries no group yet, so the app keeps a table of the current model ids; a model deployed after it lists under More models, and a catalog the table knows none of shows no headers at all.
* Agent: format the model panel and slider code
* Agent: tune the effort slider's motion after a motion audit
The slider and the status line cross-fade when levels arrive, and the status line holds the slider's height, so the panel no longer jumps. A key step moves the thumb but plays no ripple, bloom, pulse, morph or spark. A drag ripples the stops it crosses and blooms once where it lets go, instead of a landing ripple, bloom and brain pulse at every stop. The brain pulses for a pointer pick or reset only, and never replays when the panel reopens. The halo fades out when the thumb leaves the top. Opening the panel, which happens on every model switch, settles the thumb without a bounce and with the fill already in place.
* Agent: draw the recommended stop as a plain dot like the others
The ring that marked the level reset returns to read as a different kind of stop. Reset still dims at that level.
* Agent: give the Popular badge contrast that reads in light mode
The brand coral on a grey pill read at under 2:1 in the light theme. The badge now sets deep coral on the soft coral container, 5.1:1 in light and 7:1 in dark, from a new accent_text token the contrast test holds to 4.5:1.
* Agent: wrap the composer chips in narrow windows instead of overlapping them
* Agent: drop the slider thumb's coloured glow at Off
* Agent: keep waiting effort picks and keyboard Retry after the shipcheck review
* Agent: send a waiting effort pick even when its cached levels were dropped
* Agent: grey Popular badge on light, coral on dark
* Agent: darken the light Popular badge so it shows on a highlighted row
* Serve model picker groups in the catalog
Each listed model now names its `group`, and the catalog carries a
top-level `groups` array giving the sections in display order with an
English label. Clients translate a heading by group id and show the
served label for an id they do not know, so a model joins a section, and
a section is added or reordered, without a client release.
DeepSeek Uncensored gains the `Popular` badge in the existing `badges`
field. Both SDKs expose the new fields; older clients ignore them.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
* Agent: list models in the catalog's groups
The model panel kept its own table of model ids to sections, so a model
deployed after a release listed under "More models" until the next one.
The panel now takes its sections, their order and the Popular badge from
the catalog. A heading is translated by group id; a group this build has
no translation for shows the served label. Models without a served group
list last, and a catalog that serves no groups lists them unsectioned.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
* Drop the Beta badge from DeepSeek Uncensored
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
* Agent: list the models flat until the catalog groups them
The model panel kept its own table of model ids to sections and its own
list of Popular models, so a model deployed after a release listed under
More models until the next one. The catalog now serves groups and badges,
and #1540 builds the sections from it; until then the panel lists the
models flat, in the catalog's order. The group headings, the Popular
badge, its theme tokens and their strings go with the table.
* Agent: start each model at the catalog's default effort
A model with no remembered level started at Medium, moved to the nearest
level it accepts, and a switch carried the previous model's level over.
Both now take the model's `default_effort` from the catalog, which follows
the model makers' recommendations (Max for Kimi K3.1 Pro, Kimi K3 and GLM
5.3, High for DeepSeek V4.1 Flash); a model the catalog gives no default it
accepts keeps the old rule. The runtime serves that level with the levels,
and Reset to recommended returns to it.
New Task remembers one model and level, and only what the user picks
there: picking a level remembers it with the model, and picking another
model starts that model at its default and forgets the level. A task's
picks, and opening a task, leave it alone, so a task's model pick no
longer becomes the default. A level picked for a task's next model waits
in the runtime for the switch, instead of riding on the account default.
* Agent: tone the effort slider down
The slider was larger than the model rows above it and glowed strongly at
the top level, so it pulled the eye from the model list. The track is
24 px instead of 36, the thumb 27 (30 held) instead of 40 (44), and the
dots 4 instead of 5; the panel's status line keeps the slider's new
height. The fill's glow, the thumb's shadows, its held glow, the bloom
where a level lands, the top level's halo and the brain's spark there are
all softer and smaller.
* Agent: return early with ? when a model switch has no level to set
---------
Co-authored-by: Matthew Ball <13823657+matthewrball@users.noreply.github.com>
Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Maple Work changes state in a single frame almost everywhere. Menus pop, dialogs appear, the composer jumps a line at a time, new messages land without any sense of where they came from, and the whole thread jumps when a tool card arrives. This adds short, purposeful motion across the app so each change reads as cause and effect, without slowing anything down.
Every animation is 200 ms or less, eases out, and settles at once under Settings → General → Reduce motion. Transitions that can reverse (hover, switches, chevrons, the composer, the sidebar) turn back from where they are when interrupted; entrances play once. Send, Stop, Escape and keyboard shortcuts act on the frame they arrive. Streaming text, typing and keyboard navigation in menus and lists don't animate, and menus and dialogs close immediately.
The shared rules and tokens are in
apps/maple-agent/docs/motion.md, andui/motion.rsimplements them. This carries #1355 (hover transitions) forward onto current master, so #1355 can close when this lands.What this PR adds
Conversation
Composer and text fields
motion::unfoldmakes the same reveal available to any field a choice shows.Menus, dialogs and navigation
Controls
Tween.Also fixed
Preview
Recorded window-only from a local-only preview build of this branch, with sample tasks and a scripted run (no account or backend). The preview window stayed in the background the whole time, where it drew at about 30 fps, so motion looks slightly steppier here than in the focused app. The preview hook is not committed.
Validation
Run on macOS 26 with the Homebrew Rust 1.96.0 toolchain, at
ad8f7081:cargo test -p maple-agent-app --locked: 1,378 passed, 0 failed, 3 ignored.cargo clippy -p maple-agent-app -- -D warningsfor every feature set CI checks: desktop (--all-targets), headless (--all-targets --no-default-features --features acp,proxy),acponly andproxyonly. All clean. With this local toolchain, two lints already fire on master in files this PR doesn't touch (unexpected_cfgsin the Objective-C macros,clippy::nonminimal_bool), so they were allowed with-A; CI's pinned toolchain runs the real gate.cargo fmt --all --check: clean.GitHub CI on
ad8f7081:agent-lint,agent-test,agent-macosandagent-windowspass.New tests pin the motion clock (
motion::set_test_now). They cover:Visual: I drove every scenario in the GIFs through a local-only preview build of this branch, using sample tasks and a scripted run with no account or backend, and reviewed them frame by frame. That review caught three problems, fixed here before opening the PR:
Review: an independent read-only review, then advisor passes from Codex and Grok 4.7 (Gemini was out of credits) with Claude cross-checking both, found no blockers. Fixed from their notes:
Left as is: a growing field reveals its newest line as the box grows rather than scrolling it into view first; a card that appears above the composer still takes its space at once.
Hands-on testing in builds combined with other open PRs found two problems when shrinking the composer from the empty state:
render_composerwraps the box in now stretches for as long as the composer fills, not only once it's expanded.The repository pre-commit hook isn't installed in this clone (
core.hooksPathis unset), so it didn't run on these commits. I ran the app crate's checks above by hand instead; the other workspace crates are unchanged.Not verified:
Not in this PR
div, so movement is a layout-free paint offset, and press feedback stays an immediate colour change rather than a scale.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.