Repository navigation
feat(agent): replace the ACP settings form with editor setup - #1444
Merged
Merged
Conversation
Editors start `maple-agent acp` themselves, so there is nothing to turn on, but the app never said how to set one up. Add Settings > Editors after Local API, with entries to paste into Zed and JetBrains IDEs and the command for other ACP clients. The path comes from the running installation and survives updates: the macOS bundle, the Linux wrapper or AppRun, and the stable Windows launcher rather than a versions/ generation. Remove the per-account ACP settings. Maximum connections was never read. Allowed project folders only limited where a session started and which sessions were listed; it never confined the agent. Saved values are now ignored. Session folders must still resolve to an absolute path, and project trust is unchanged. Release builds have no password controls, which left Privacy & Security holding only this form. List it only when it has something to show. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The ACP settings sat at the bottom of Privacy & Security, under an empty "Local data" heading, and gave no setup instructions. Editors start
maple-agent acpthemselves, so nothing has to be turned on, but nothing told people how to connect one.The settings on that form also didn't do what they implied:
MAX_CLIENTS.maple-agent acpalready runs as the user.What changed
Maple Agent.appbecause the bundle name predates the branding. It warns if the app is on a disk image or translocated, reusing the updater's check.~/.local/bin/<command>, or the bundle'sAppRunwhen not installed.versions/generation, without the\\?\prefix.docs/local-host.mdand a new scenario checklist row. Public docs are out of scope here.Behaviour change: an existing saved
acpsetting is now ignored, so a saved folder list stops applying. The stored row is left in place, unread.Testing
just ci-lintandjust ci-extrapass.just lane repopasses.reads_native_release_tar_format_and_preserves_bundle_modes, in untouched updater code, a known failure with this Mac'sbsdtar.initializeandsession/newsucceed from a folder with no allowlist, and closing stdin exits 0. Signed out,acpstill exits 1 with its stderr message.Committed with
MAPLE_HOOK_SKIP=1. The hook stops on thebsdtarfailure above and ontest_deb_normalization_refreshes_checksums_and_verifier_rejects_tampering, which is #1438 (fix in #1439) and touches nothing in this change. The checks above were run separately.Not tested
Nix installs will show a store path that changes on upgrade; this isn't handled.
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.