Skip to content

feat(agent): replace the ACP settings form with editor setup - #1444

Merged
AnthonyRonning merged 1 commit into
masterfrom
claude/editors-settings-page
Nov 4, 2026
Merged

AnthonyRonning merged 1 commit into
masterfrom
claude/editors-settings-page

Conversation

@AnthonyRonning

@AnthonyRonning AnthonyRonning commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Why

The ACP settings sat at the bottom of Privacy & Security, under an empty "Local data" heading, and gave no setup instructions. Editors start maple-agent acp themselves, so nothing has to be turned on, but nothing told people how to connect one.

The settings on that form also didn't do what they implied:

  • Maximum connections was never read outside its own config code and tests. The only real cap is the host-wide MAX_CLIENTS.
  • Allowed project folders only limited where a session could start and which sessions were listed. It never confined the agent, which has bash and runs tools without asking, and anything able to launch maple-agent acp already runs as the user.

What changed

  • New Settings → Editors page, right after Local API. It shows copy-ready entries for Zed and JetBrains IDEs, plus the command for other ACP clients, with notes on trust, tool approval, what only works in the app, and what to do if the editor can't start Maple. Nothing on the page is saved.
  • Install-specific paths that keep working after updates:
    • macOS uses the running app, which is Maple Agent.app because the bundle name predates the branding. It warns if the app is on a disk image or translocated, reusing the updater's check.
    • Linux uses ~/.local/bin/<command>, or the bundle's AppRun when not installed.
    • Windows uses the stable launcher rather than a versions/ generation, without the \\?\ prefix.
  • ACP settings removed: the config type, storage, host commands and form. Session folders must still resolve to an absolute path, and project trust is unchanged.
  • Privacy & Security is listed only when it has something to show. Release builds have no password controls, so it would otherwise be empty. If reached with nothing to show, it says so instead of showing a bare heading.
  • Repo docs updated: README, docs/local-host.md and a new scenario checklist row. Public docs are out of scope here.

Behaviour change: an existing saved acp setting is now ignored, so a saved folder list stops applying. The stored row is left in place, unread.

Testing

  • just ci-lint and just ci-extra pass. just lane repo passes.
  • Workspace tests: 2,892 passed, 1 failed. The failure is reads_native_release_tar_format_and_preserves_bundle_modes, in untouched updater code, a known failure with this Mac's bsdtar.
  • Viewed Settings → Editors and Privacy & Security in the debug app, signed in with a local fixture account.
  • Against the changed build, signed in: ACP initialize and session/new succeed from a folder with no allowlist, and closing stdin exits 0. Signed out, acp still exits 1 with its stderr message.
  • New unit tests cover launcher paths for each layout, JSON validity with spaces and backslashes, shell quoting, every copy target, and when Privacy & Security is listed.

Committed with MAPLE_HOOK_SKIP=1. The hook stops on the bsdtar failure above and on test_deb_normalization_refreshes_checksums_and_verifier_rejects_tampering, which is #1438 (fix in #1439) and touches nothing in this change. The checks above were run separately.

Not tested

  • The Zed and JetBrains entries in real editors. They follow each editor's current docs; checklist row A4 tracks this.
  • A release build. The hidden Privacy & Security state is covered by a unit test only, because debug builds always have the password controls.
  • Real Windows and Linux installs. Path handling is unit tested only.
  • Real clicks on the copy buttons, and dark mode.

Nix installs will show a store path that changes on upgrade; this isn't handled.

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

Editors start `maple-agent acp` themselves, so there is nothing to turn on,
but the app never said how to set one up. Add Settings > Editors after Local
API, with entries to paste into Zed and JetBrains IDEs and the command for
other ACP clients. The path comes from the running installation and survives
updates: the macOS bundle, the Linux wrapper or AppRun, and the stable Windows
launcher rather than a versions/ generation.

Remove the per-account ACP settings. Maximum connections was never read.
Allowed project folders only limited where a session started and which
sessions were listed; it never confined the agent. Saved values are now
ignored. Session folders must still resolve to an absolute path, and project
trust is unchanged.

Release builds have no password controls, which left Privacy & Security
holding only this form. List it only when it has something to show.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@AnthonyRonning
AnthonyRonning merged commit 5a94ae8 into master Nov 4, 2026
23 checks passed
@AnthonyRonning
AnthonyRonning deleted the claude/editors-settings-page branch November 4, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant