Repository navigation
Fix Research Debian checksums after ELF sanitization - #1426
Merged
Merged
Conversation
Contributor
|
Maple Auth development preview: https://0c9f685d.maple-auth-dev.pages.dev Commit: Uses development services. Cloudflare Access applies. Provider OAuth is not configured for PR URLs; use the stable Auth Dev host for OAuth rehearsal. |
Contributor
|
Maple development preview: https://89b360ee.maple-ca8.pages.dev Commit: Uses development API, billing, flags and PCR configuration. Cloudflare Access applies. |
AnthonyRonning
approved these changes
Nov 2, 2026
AnthonyRonning
left a comment
Contributor
There was a problem hiding this comment.
Reviewed: no blockers. The RPM/AppImage input (data.tar.gz) is byte-identical to master on the v3.4.6 .deb; only control/md5sums changes. The new .deb installs cleanly with debsums and dpkg --verify. Other OSs are untouched.
AnthonyRonning
added a commit
that referenced
this pull request
Nov 4, 2026
The test added in #1426 runs normalize_deb_package with the shell's ar. On Darwin that is llvm-ar, whose default BSD format pads members. The padding survives extraction, and GNU tar treats gzip's trailing garbage warning as fatal, so any Mac commit running the repo hook component stopped here. Have this test write GNU archives, which is what a Debian package is, when ar is llvm-ar. Packaging scripts and GNU ar runs are unchanged. Fixes #1438 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debian integrity scanners report
/usr/bin/mapleas modified on a clean Research install because post-bundle ELF sanitization changes the executable after Tauri writesmd5sums. This was reproduced in the official v3.1.1, v3.2.0, v3.3.0, and v3.4.4 packages; v3.1.0 passes.Regenerate the manifest from the final regular payload files after sanitization, excluding symlinks and sorting paths deterministically. Verify the packaged manifest alongside the existing ELF and bundle-type checks before signing. The regression test exercises executable mutation, a resource filename containing spaces, symlink exclusion, and rejection of later payload tampering. Add the archive and find tools to the existing Nix test environments.
Validation:
just lane repopassed on x86_64 Linux (537 CI-script tests; two RPM-tool tests skipped in the check sandbox).git diff --checkpassed.No full Research application build or installed-app runtime test was run locally. Existing published artifacts are unchanged; this fixes future packages.
Need help on this PR? Tag
@codesmith-botwith what you need.