Skip to content

Fix Research Debian checksums after ELF sanitization - #1426

Merged
AnthonyRonning merged 1 commit into
masterfrom
fix/research-deb-checksums
Nov 2, 2026
Merged

AnthonyRonning merged 1 commit into
masterfrom
fix/research-deb-checksums

Conversation

@w3irdrobot

@w3irdrobot w3irdrobot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Debian integrity scanners report /usr/bin/maple as modified on a clean Research install because post-bundle ELF sanitization changes the executable after Tauri writes md5sums. This was reproduced in the official v3.1.1, v3.2.0, v3.3.0, and v3.4.4 packages; v3.1.0 passes.

Regenerate the manifest from the final regular payload files after sanitization, excluding symlinks and sorting paths deterministically. Verify the packaged manifest alongside the existing ELF and bundle-type checks before signing. The regression test exercises executable mutation, a resource filename containing spaces, symlink exclusion, and rejection of later payload tampering. Add the archive and find tools to the existing Nix test environments.

Validation:

  • just lane repo passed on x86_64 Linux (537 CI-script tests; two RPM-tool tests skipped in the check sandbox).
  • All 14 packaging tests passed in the pinned development shell, including the real RPM tests.
  • A local copy of the official v3.4.4 Debian package failed the new verifier before normalization and passed all six checksums, ELF metadata, and Tauri bundle identity afterward.
  • Planner lint, Bash syntax, and git diff --check passed.

No full Research application build or installed-app runtime test was run locally. Existing published artifacts are unchanged; this fixes future packages.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@w3irdrobot w3irdrobot added the ci:package Build unsigned packages on this PR label Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Maple Auth development preview: https://0c9f685d.maple-auth-dev.pages.dev

Commit: 7cc4f05a28597acf82706c62f26c50e226753dd0

Uses development services. Cloudflare Access applies. Provider OAuth is not configured for PR URLs; use the stable Auth Dev host for OAuth rehearsal.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Maple development preview: https://89b360ee.maple-ca8.pages.dev

Commit: 7cc4f05a28597acf82706c62f26c50e226753dd0

Uses development API, billing, flags and PCR configuration. Cloudflare Access applies.

@AnthonyRonning AnthonyRonning left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed: no blockers. The RPM/AppImage input (data.tar.gz) is byte-identical to master on the v3.4.6 .deb; only control/md5sums changes. The new .deb installs cleanly with debsums and dpkg --verify. Other OSs are untouched.

@AnthonyRonning
AnthonyRonning merged commit ca8290b into master Nov 2, 2026
28 checks passed
@AnthonyRonning
AnthonyRonning deleted the fix/research-deb-checksums branch November 2, 2026 03:18
AnthonyRonning added a commit that referenced this pull request Nov 4, 2026
The test added in #1426 runs normalize_deb_package with the shell's ar. On
Darwin that is llvm-ar, whose default BSD format pads members. The padding
survives extraction, and GNU tar treats gzip's trailing garbage warning as
fatal, so any Mac commit running the repo hook component stopped here.

Have this test write GNU archives, which is what a Debian package is, when
ar is llvm-ar. Packaging scripts and GNU ar runs are unchanged.

Fixes #1438

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

This branch was successfully deployed

2 active deployments
pages-pr-1426 — 7cc4f05a Deployed Nov 2, 2026 by github-actions[bot]
auth-pages-pr-1426 — 7cc4f05a Deployed Nov 2, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:package Build unsigned packages on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants