Repository navigation
ios-native parity pass 2: chat, composer, and library - #1155
Merged
AnthonyRonning merged 20 commits intoOct 14, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the native Swift chat, composer and library closer to Research while extending Mark’s existing components. Thinking choices are captured with queued turns, background refresh preserves account and run ownership, older-page loading retains the visible message position, and project detail shares the existing instructions and selection controls. The final changes also correct cancellation and polling recovery, declined image-paste fallback, legacy rendering publication, and library navigation/copy. A fresh direct send also starts a new queue session when the previous queue is empty, clearing a stale pause after Stop, reload or reconnect while preserving paused pending messages and edits.
Base:
codex-ios-native-swiftat6baf139caf2d4c91b726274d2ab173a123996772. Research reference:2f22d3375c4e420413e619a0b4be1b742532e2cd;R/below meansapps/maple-research/frontend/src/at that commit. Final head:7b986bbe2017a1cf19a38d8cc97f2157b5334f01. 20 signed commits (14 item commits and 6 review-fix commits), retaining the configured identity and OpenPGP signing.chatThinkingLevelpersistence, effort captured at submission/queue admission, nested request encoding, native options row and non-default trigger label. Future effort strings remain decodable without becoming unsupported request choices.R/state/LocalStateContextDef.ts,R/services/chatThinkingLevel.ts,R/services/chatComposerQueue.ts,R/components/chat/ThinkingLevelSelector.tsx,R/components/UnifiedChat.tsxrequest construction.R/components/UnifiedChat.tsx:3103–3306,4910–4921,R/services/chatPollingPage.ts, existing native streaming merge helpers.R/components/ChatHistoryList.tsx:288–342,476–487,1215–1225.R/components/markdown.tsx:530–702.R/components/ToolActivityCard.tsx:194–315,R/services/chatToolPresentation.ts,R/services/toolPresentation.ts,R/utils/markdown.ts.R/components/chatComposerListContinuation.ts,R/components/UnifiedChat.tsx:5659–5670.R/components/UnifiedChat.tsx:3936–4070,R/utils/imagePaste.ts.R/components/UnifiedChat.tsx:3384–3783,5795–5803,R/components/chatHistoryPagination.ts.R/components/UnifiedChat.tsx:266–268,3853–3870,3908–3923,5351–5354,5450–5453,R/components/markdown.tsx:195–259,704–767.R/components/ChatHistoryList.tsx:119–146,189–192,1251–1329,1476–1531,R/services/chatRuntimeStore.ts.R/components/ProjectDetailView.tsx:231–284,586–592,617–929,R/components/ChatHistoryList.tsx:972–989,1012–1019,1534–1578.R/components/CreditUsage.tsx,R/utils/dateFormat.ts,R/components/AccountMenu.tsx.R/components/team/TeamSeatMismatchAlert.tsx,R/utils/teamSeats.ts.R/components/RenameChatDialog.tsx,DeleteChatDialog.tsx,BulkDeleteDialog.tsx,ConversationProjectDialog.tsx,DeleteConversationProjectDialog.tsx,ProjectDetailView.tsx:86–165.Hardware Return sends on iPhone; software Return and Shift-Return insert a newline, following the native specification. Empty-draft submission is ignored. Clipboard providers are read sequentially to retain the existing temporary-memory budget. A cross-app multi-provider authorization failure was not reproduced, so no speculative eager provider loading was added. The catalog’s required
mandatoryBoolean follows the published contract.Conversation and recents polls serialize their reads and begin the next delay afterward, so request duration adds to the nominal interval. The existing native recents query uses
pinned=false; Research fetches unassigned rows and removes pinned rows when rendering. The existing ChatDetail storage-owner remount race is corrected by recomputing visibility through AppEnvironment’s registry. Preparation receipts are tied to the current rendered item/result/turn; obsolete detached parsing can finish in memory, but stale publication is rejected.Navigation/CompactMenuNavigation.swiftis unchanged. The diff stays withinapps/maple-ios/andsdk/swift/. Bundle identity, URL schemes, xcconfig values, signing entitlements, Info.plist, workflows, CI scripts, flakes, StoreKit, guest/team settings, verification, billing/API pages and document attachment features remain outside this change. Local runtime configuration is ignored and generated from allowlisted public endpoints. Final diff: 79 files; 7,559 additions and 552 deletions (8,111 changed lines). All 14 items remain together, without file moves or unrelated refactors.Two inherited behaviors remain deferred:
The usage summary lives in Settings under Usage, keeping the sidebar focused on chat navigation and search. Its billing-derived values, localization, clamped percentage and reset-date behavior follow Research; its placement follows the intended native layout. Plan refresh and team-seat attention remain in their existing account-owned paths.
Final Settings placement validation for
7b986bbe2017a1cf19a38d8cc97f2157b5334f01:.nilError. Source log:/tmp/ios-parity-pass2-settings-usage-app-gate.log./tmp/ios-parity-pass2-settings-usage-{cross-build,simulator-build,runtime-build}.log./tmp/ios-parity-pass2-settings-usage-ui-{phone,ipad}.{log,xcresult}./tmp/ios-parity-pass2-settings-usage-human-smoke-ready.json. The checkout is clean and all source paths remain within the two allowed directories.Queue correction validation at
ab09f25f451c1c04b0bddbffc6361a7bd3444bd3:/tmp/ios-parity-pass2-empty-queue-baseline-2.logand/tmp/ios-parity-pass2-empty-queue-fixed-2.log..nilErrorbelow. Log:/tmp/ios-parity-pass2-queue-app-gate.log./tmp/ios-parity-pass2-queue-cross-build.log,/tmp/ios-parity-pass2-queue-simulator-build.logand/tmp/ios-parity-pass2-queue-runtime-build.log./tmp/ios-parity-pass2-queue-ui-phone.{log,xcresult}and/tmp/ios-parity-pass2-queue-ui-ipad.{log,xcresult}.8EF68006-89EB-4225-938C-8D207B4506DF, retaining its account/storage. Executable and Info.plist bytes were verified against the tested artifact; the phone was reopened on a fresh chat for human smoke. Metadata:/tmp/ios-parity-pass2-queue-human-smoke-ready.json. This observation and human smoke are separate from injected-service tests; no fresh production-provider claim is made.Earlier full parity validation at
669ec24c1da10b798b3eb0982fbfc6ac9386da8e:593/594 tests in 74 suites passed; strict formatting/lint passed. The known untouched-base Vision.nilErrorinImageScreenshotTests.denseScreenshotActuallyDownscalesToTheBoundedLosslessWireImageis preserved; its implementation and test are unchanged./tmp/ios-parity-pass2-r2-ui-phone-1.{log,xcresult},/tmp/ios-parity-pass2-r2-ui-phone-anchors-2.{log,xcresult}, and/tmp/ios-parity-pass2-r2-ui-phone-settings-6.{log,xcresult}./tmp/ios-parity-pass2-r2-ui-ipad-1.{log,xcresult}and/tmp/ios-parity-pass2-r2-ui-ipad-library-4.{log,xcresult}. The final rerun covers Library → Project → Custom Instructions → Settings and preserves the original frame assertions.The linked Local stack smoke passed at the prior reviewed headbb50b31; this follow-up does not claim a fresh live-provider smoke. Its regression runs use production components with injected services.apps/maple-ios/andsdk/swift/; navigation-controller source is unchanged.Runtime fixtures exercise production components with injected services on owned iPhone
0C7E271E-EFE3-4D02-A317-09E3CD57F814and iPadB2096BF9-D6BC-47D0-98DB-9FA56A45587Csimulators using the Local profile (cloud.opensecret.maple.native.dev, 0.1.0/build 8). Exact bundle:/Users/admin/workspaces/ios-parity-pass2/apps/maple-ios/.build/xcode-local/Build/Products/Local-iphonesimulator/Maple.app. Public endpoints: APIhttp://127.0.0.1:31714, billing:36972, flags:41248, browser auth:35694; public client UUIDba5a14b5-d915-47b1-b7b1-afda52bc5fc6. Xcode 26.5/17F42 and iOS 26.5/23F77. The manual phone8EF68006-89EB-4225-938C-8D207B4506DFand unrelated devices are preserved. Hosted auth, production inference/billing lifecycle, distribution and physical camera/microphone behavior remain untested. OCR hardware testing remains deferred.Separately, owned probes of Xcode 26.5 clang were confirmed to hang:
the ownedclang -v -E -dM -isysroot …iPhoneSimulator26.5.sdk -x c -c /dev/nullsubprocess repeatedly stayed asleep. After verifying each parent belonged to this checkout’s Local/PR build, only that stalled probe was terminated; the builds then passed. Evidence is in the runtime-build and canonical simulator-build logs. No build flags, CI scripts or toolchains were changed. These compiler diagnostics are recorded separately from the source-specific gate and native results above.The requested verbatim gate tails are included below.
scripts/ci/sdk-swift.shapps/maple-ios/scripts/build.sh unitscripts/ci/ios-native.sh simulator-buildGate environment:
Pinnednix develop --no-update-lock-file .#applewithDEVELOPER_DIR=/Applications/Xcode_26.5.app/Contents/Developer, Xcode 26.5/17F42. Commits use the documentedMAPLE_HOOK_SKIP=1after the explicit gates because the VM hook wrapper selects the Command Line Tools SDK. Generated Textual lockfile drift is restored; no dependency change is included. Follow-up refactoring, account surfaces, documents, IAP and lane/identity work remain separate work.