Skip to content

Make Agent signing keychain visible to codesign - #1077

Merged
AnthonyRonning merged 1 commit into
masterfrom
codex/agent-macos-signing-fix
Oct 5, 2026
Merged

AnthonyRonning merged 1 commit into
masterfrom
codex/agent-macos-signing-fix

Conversation

@AnthonyRonning

Copy link
Copy Markdown
Contributor

The first signed Agent master run built both profiles and passed static metadata validation, but both macOS jobs stopped at the first codesign call with no identity found. The certificate was present in the temporary keychain; that keychain was missing from the user search list required for signing. Apple's keychain implementation confirms private keychain creation does not add it automatically.

Snapshot the existing search list before creating the temporary keychain, append that keychain while signing, and restore the original list before deleting it on success, failure, or signals. Preserve raw quoted paths, including spaces, literal quotes, and backslashes; reject malformed snapshot output before setup. A restoration failure makes packaging fail. The default keychain, Apple credentials, and static-only artifact validation are unchanged.

Validation:

  • 25 packaging fixtures pass. The native signing fixture now requires the selected SHA-1's explicit keychain to be on the search list, reproducing the observed lookup boundary. It covers empty lists, quoted paths, partial setter failure, signing/notary/signal cleanup, and restoration failure.
  • Root pinned Nix flake checks pass.
  • Full required Agent pre-commit gates pass, including all feature-set format/Clippy/build/tests.
  • Independent review found no remaining code blocker. No real local keychain changes or credential-value access were needed.

Fixes the first signed run after #1072: 37271547460. The actual signing/notarization path needs a fresh master run after this fix; both Linux master packages already passed provenance and downloaded-artifact verification.

@AnthonyRonning
AnthonyRonning merged commit 02f73ce into master Oct 5, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant