Repository navigation
Make Agent signing keychain visible to codesign - #1077
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first signed Agent master run built both profiles and passed static metadata validation, but both macOS jobs stopped at the first
codesigncall withno identity found. The certificate was present in the temporary keychain; that keychain was missing from the user search list required for signing. Apple's keychain implementation confirms private keychain creation does not add it automatically.Snapshot the existing search list before creating the temporary keychain, append that keychain while signing, and restore the original list before deleting it on success, failure, or signals. Preserve raw quoted paths, including spaces, literal quotes, and backslashes; reject malformed snapshot output before setup. A restoration failure makes packaging fail. The default keychain, Apple credentials, and static-only artifact validation are unchanged.
Validation:
Fixes the first signed run after #1072: 37271547460. The actual signing/notarization path needs a fresh master run after this fix; both Linux master packages already passed provenance and downloaded-artifact verification.