Skip to content

Desktop download logic #89

Closed
Closed

Description

@AnthonyRonning

Right now the download page has logic that pulls from the current NPM version on the web app for deciding what link the download link is for desktop. This is not quite accurate since we often bump version earlier than we cut a desktop release. can we do something like parse the "latest" logic in github for finding the link?

We do something similar in the src-tauri download logic, could we do it on the download page too? You can ignore all the signature checking stuff, just focus on getting the latest version that's released and crafting the correct download links for each desktop OS version.

Activity

  1. AnthonyRonning commented on Jun 2, 2025

    @AnthonyRonning
    ContributorAuthor

    @claude can you handle this issue and submit a PR with your committed changes?

  2. claude commented on Jun 2, 2025

    @claude
    Contributor

    Claude finished @AnthonyRonning's task in 4m 9s —— View job • claude/issue-89-20250602_170246 • Create PR ➔


    Desktop Download Logic Issue - Complete ✅

    I've successfully fixed the desktop download logic to use GitHub's latest release instead of NPM version.

    Todo List:

    • Read repository guidelines (CLAUDE.md)
    • Analyze current download page logic
    • Examine existing src-tauri download logic for reference
    • Implement GitHub latest release parsing
    • Update download page with new logic
    • Run linting and formatting commands (Unable to run - Bash access not granted)
    • Commit changes and provide PR link

    Analysis:

    Current Issue: The downloads page at frontend/src/routes/downloads.tsx pulls version from package.json (currently v1.0.10) to construct GitHub release URLs. This causes mismatch when NPM version is bumped before desktop releases.

    Solution: Create a utility to fetch the latest GitHub release dynamically, similar to the existing Tauri updater logic that uses the GitHub releases API.

    Reference Implementation: Found comprehensive update logic in frontend/src-tauri/src/lib.rs that uses the GitHub releases API endpoint and Tauri's updater plugin.

    Changes Made:

    1. Created frontend/src/utils/githubRelease.ts - Utility functions to fetch latest GitHub release
    2. Updated frontend/src/routes/downloads.tsx - Now uses dynamic GitHub API calls with fallback to package.json version
    3. Features:
      • Fetches latest release from GitHub API on page load
      • Graceful fallback to package.json version if API fails
      • Loading indicator while fetching
      • Dynamic download URLs for all desktop platforms
      • Real-time release notes link

    Note:

    ⚠️ Unable to run bun run format and bun run lint due to missing Bash permissions. Please run these commands manually after reviewing the PR to ensure code quality.

    Commit: 6da262c - Changes pushed to branch claude/issue-89-20250602_170246


  3. added a commit that references this issue on Jun 2, 2025
    6da262c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions