Skip to content

Fence manual proxy startup against logout and account transitions #655

Closed as not planned

Description

@AnthonyRonning

Problem

First-time manual proxy startup creates an API key before entering the serialized proxy operation. If API-key creation or the following key-list refresh is delayed while the user logs out, logout can reset the proxy first and the stale startup handler can enqueue a new start afterward using the prior account's key.

The component-level account guard explored in PR #652 would only partially mitigate this: it can leave a newly created remote key orphaned and does not move the account boundary into the service lifecycle.

Expected behavior

A manual proxy setup started by one authenticated account must not persist or start after that account logs out or another account becomes active.

Suggested direction

  • Fence manual proxy startup at the lifecycle or service boundary using the initiating account and an auth generation.
  • Coordinate key creation with logout cleanup rather than guarding only the React component.
  • Revoke or otherwise roll back a key created by an operation that becomes stale.
  • Add a deterministic test using delayed key creation followed by logout and account transition.

Track and fix this separately from the documentation and UI work in PR #652.

Activity

  1. added
    bugSomething isn't working
    securitySecurity-related feature or issue
    on Jul 20, 2026
  2. AnthonyRonning commented on Jul 29, 2026

    @AnthonyRonning
    ContributorAuthor

    Closing as not planned. We implemented and validated a fix in #711, including a master-to-PR upgrade check, but decided this hypothetical in-flight startup race has no reported real-world instances and does not justify the additional lifecycle complexity. Existing logout already stops and scrubs the local proxy, so we are keeping the current behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingsecuritySecurity-related feature or issue

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions