Skip to content

Modern GDAL Integration for MapWinGIS6 - #9

Merged
pmeems merged 5 commits into
developmentfrom
phase-4-modern-gdal-capabilities
Oct 25, 2026
Merged

pmeems merged 5 commits into
developmentfrom
phase-4-modern-gdal-capabilities

Conversation

@pmeems

@pmeems pmeems commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

Adds COG creation, direct VSI-path usage guidance, VRT mosaic coverage, and sequential pipelines that pass referenced GDAL datasets in memory. WriteCog delegates to raster convert and forwards COG creation options; RunPipeline returns owned output datasets and structured diagnostics.

Cloud credentials remain caller-configured through GDAL options; none are embedded or logged. The implementation uses the existing GDAL 3.12.4 dependency and adds no new dependencies. Multidimensional/Zarr access remains dependent on GDAL build capabilities and is available only through the generic runner when registered.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Dataset ownership and pipeline failure cleanup lack regression coverage and need validation on the supported GDAL build.

2 open issues
What changed in this PR

This PR extends MapWinGIS6’s GDAL integration with COG creation and sequential pipelines that pass datasets in memory, using the existing dependency.

Changes:

  • Adds WriteCog, pipeline execution, and referenced dataset arguments.
  • Adds COG, in-memory pipeline, VRT mosaic, and opt-in network tests.
  • Documents VSI paths, caller-managed cloud credentials, and build-dependent capabilities.

Builds and tests were not run.

File Description
tests/​MapWinGIS.Core.Tests/​MapWinGIS.Core.Tests.vcxproj Registers the new capability tests.
tests/​MapWinGIS.Core.Tests/​GdalModernCapabilitiesTests.cpp Tests COG creation, pipelines, mosaics, and remote access.
src/​MwGdalCore/​MwGdalCore.vcxproj Registers the new GDAL implementation and header.
src/​MwGdalCore/​GdalModern.cpp Implements COG creation and sequential pipelines.
src/​MwGdalCore/​GdalAlgorithmRunner.cpp Adds referenced dataset argument assignment.
src/​MapWinGIS.Core/​MapWinGIS.Core.vcxproj Registers the public capability header.
src/​MapWinGIS.Core/​include/​mapwingis/​gdal/​GdalModern.h Declares operation results, options, and pipeline APIs.
src/​MapWinGIS.Core/​include/​mapwingis/​gdal/​GdalAlgorithmRunner.h Exposes the dataset argument setter.
docs/​gdal-modern-capabilities.md Documents modern GDAL usage and capability limits.

Review effort: Balanced

Comment thread src/MwGdalCore/GdalAlgorithmRunner.cpp Resolved
Comment thread src/MwGdalCore/GdalModern.cpp Resolved
pmeems and others added 2 commits October 25, 2026 18:15
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@pmeems pmeems left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the new GDAL convenience operations and pipeline ownership behavior. I left an inline comment on a potential lifetime issue with VRT/intermediate datasets. The PR's existing Copilot review notes that builds/tests were not run, so please ensure the supported Windows/GDAL build and test suite pass before merging.

Comment thread src/MwGdalCore/GdalModern.cpp Resolved
pmeems and others added 2 commits October 25, 2026 20:25
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pmeems
pmeems merged commit bc48712 into development Oct 25, 2026
1 check passed
@pmeems
pmeems deleted the phase-4-modern-gdal-capabilities branch October 25, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants