Repository navigation
Modern GDAL Integration for MapWinGIS6 - #9
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Dataset ownership and pipeline failure cleanup lack regression coverage and need validation on the supported GDAL build.
2 open issues
What changed in this PR
This PR extends MapWinGIS6’s GDAL integration with COG creation and sequential pipelines that pass datasets in memory, using the existing dependency.
Changes:
- Adds
WriteCog, pipeline execution, and referenced dataset arguments. - Adds COG, in-memory pipeline, VRT mosaic, and opt-in network tests.
- Documents VSI paths, caller-managed cloud credentials, and build-dependent capabilities.
Builds and tests were not run.
| File | Description |
|---|---|
| tests/MapWinGIS.Core.Tests/MapWinGIS.Core.Tests.vcxproj | Registers the new capability tests. |
| tests/MapWinGIS.Core.Tests/GdalModernCapabilitiesTests.cpp | Tests COG creation, pipelines, mosaics, and remote access. |
| src/MwGdalCore/MwGdalCore.vcxproj | Registers the new GDAL implementation and header. |
| src/MwGdalCore/GdalModern.cpp | Implements COG creation and sequential pipelines. |
| src/MwGdalCore/GdalAlgorithmRunner.cpp | Adds referenced dataset argument assignment. |
| src/MapWinGIS.Core/MapWinGIS.Core.vcxproj | Registers the public capability header. |
| src/MapWinGIS.Core/include/mapwingis/gdal/GdalModern.h | Declares operation results, options, and pipeline APIs. |
| src/MapWinGIS.Core/include/mapwingis/gdal/GdalAlgorithmRunner.h | Exposes the dataset argument setter. |
| docs/gdal-modern-capabilities.md | Documents modern GDAL usage and capability limits. |
Review effort: Balanced
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…-gdal-capabilities
pmeems
commented
Oct 25, 2026
pmeems
left a comment
Contributor
Author
There was a problem hiding this comment.
Reviewed the new GDAL convenience operations and pipeline ownership behavior. I left an inline comment on a potential lifetime issue with VRT/intermediate datasets. The PR's existing Copilot review notes that builds/tests were not run, so please ensure the supported Windows/GDAL build and test suite pass before merging.
…-gdal-capabilities
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds COG creation, direct VSI-path usage guidance, VRT mosaic coverage, and sequential pipelines that pass referenced GDAL datasets in memory.
WriteCogdelegates toraster convertand forwards COG creation options;RunPipelinereturns owned output datasets and structured diagnostics.Cloud credentials remain caller-configured through GDAL options; none are embedded or logged. The implementation uses the existing GDAL 3.12.4 dependency and adds no new dependencies. Multidimensional/Zarr access remains dependent on GDAL build capabilities and is available only through the generic runner when registered.