You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Plan: resolve the pre-merge review findings – MapWinGIS6 development - #75
Make the Shapefile feature ID index authoritative for exact feature counts, excluding deleted DBF records and keeping indexed access consistent with sequential geometry iteration.
Bound invalid-WKT diagnostics to a UTF-8-safe 200-byte excerpt and include the original byte length.
Add regression coverage for deleted records, count stability around geometry iteration, and multibyte truncation.
Local builds and tests were intentionally skipped under the agreed GitHub-only workflow. GitHub Actions must validate the changes before the phase can be marked complete. The GitHub file-edit workflow produced several focused commits rather than a single consolidated commit.
- Verify deleted Shapefile records are excluded from indexed access
- Check feature counts before and after geometry iteration
- Cover multibyte UTF-8 truncation at the excerpt boundary
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The Core test target cannot compile without the OGRLayer definition, and automatic repacking prevents the new regression test from detecting the original overcounting bug.
…on test
Include ogrsf_frmts.h for OGRLayer, open the fixture with AUTO_REPACK=NO and assert the raw driver count still includes the deleted record. Record local validation and memory notes.
Co-authored-by: Junie <junie@jetbrains.com>
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
The GDAL reopen calls use path.string(), which can misencode non-ASCII temporary-directory paths on Windows and cause test failures; both should use UTF-8 paths.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Use UTF-8 paths when reopening GDAL datasets on Windows
On Windows with a non-UTF-8 system code page, path.string() can pass incorrectly encoded filenames to GDAL, causing this test to fail when the temporary-directory path contains non-ASCII characters. Convert both GDAL reopen paths to UTF-8 with path.u8string(), matching the fixture's UTF-8 creation path in TestData.cpp:458. The same issue occurs in the read-only reopen at line 256; the suggested fix covers both calls.
Fixed in 3ea69d1: both GDAL reopen calls in ExcludesDeletedShapefileRecordsFromFeatureCount now pass a UTF-8 path (path.u8string(), same helper pattern as TestData.cpp), so non-ASCII temporary-directory paths work on non-UTF-8 code pages. MSBuild Debug x64 builds without warnings; Core tests pass locally (314 passed, 1 network test skipped).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Phase 2 against
development.Local builds and tests were intentionally skipped under the agreed GitHub-only workflow. GitHub Actions must validate the changes before the phase can be marked complete. The GitHub file-edit workflow produced several focused commits rather than a single consolidated commit.