Skip to content

Modern GDAL Integration for MapWinGIS6 - #7

Merged
pmeems merged 2 commits into
developmentfrom
phase-3-backward-compatibility
Oct 25, 2026
Merged

pmeems merged 2 commits into
developmentfrom
phase-3-backward-compatibility

Conversation

@pmeems

@pmeems pmeems commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

Phase 3 adds deprecated native C++ GdalUtils methods for the six MapWinGIS 5 operations, preserving GDAL utility flags and mapping diagnostics to legacy-style error properties. The ActiveX wrapper is not implemented, so this keeps the API COM-free.

GDAL utility APIs handle legacy CLI options that the current typed algorithms do not expose; vector clipping uses GdalAlgorithmRunner. Adds migration guidance and operation-level tests. Uses the existing pinned GDAL dependency; no new packages.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Output-finalization failures, legacy behavior regressions, and configuration restoration issues remain unresolved.

5 open issues
What changed in this PR

Adds a native, COM-free compatibility bridge for six MapWinGIS 5 GDAL operations while directing new code toward the existing algorithm runner and typed options.

Changes:

  • Adds deprecated GdalUtils methods with legacy utility flags and GDAL diagnostic properties.
  • Adds operation-level tests and registers the API, implementation, and tests in the build projects.
  • Documents migration paths and native-versus-COM compatibility boundaries.

Builds and tests were not run.

File Description
tests/​MapWinGIS.Core.Tests/​MapWinGIS.Core.Tests.vcxproj Registers compatibility tests.
tests/​MapWinGIS.Core.Tests/​GdalUtilsTests.cpp Tests operations, options, and error reporting.
src/​MwGdalCore/​MwGdalCore.vcxproj Registers the compatibility implementation and header.
src/​MwGdalCore/​GdalUtils.cpp Implements six operations and diagnostic handling.
src/​MapWinGIS.Core/​MapWinGIS.Core.vcxproj Registers the public compatibility header.
src/​MapWinGIS.Core/​include/​mapwingis/​gdal/​GdalUtils.h Declares the deprecated native API and contracts.
docs/​PORTING.md Links GDAL migration guidance.
docs/​gdal-migration.md Explains compatibility methods and recommended replacements.

Review effort: Balanced

Comment thread src/MwGdalCore/GdalUtils.cpp Resolved
Comment thread src/MwGdalCore/GdalUtils.cpp Resolved
Comment thread src/MwGdalCore/GdalUtils.cpp Resolved
Comment thread src/MwGdalCore/GdalUtils.cpp Resolved
Comment thread src/MwGdalCore/GdalUtils.cpp Resolved
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@pmeems pmeems left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of the current head (90f8608): I found no additional actionable defects beyond the issues already raised in the existing inline threads, which appear to have been addressed with corresponding regression tests. The Debug/x64 CI check is passing. The main design caveat is already documented appropriately: these are native C++ compatibility methods, not a COM-compatible replacement for the v5 ActiveX API; the future wrapper will still need to translate COM values and legacy error semantics.

@pmeems
pmeems merged commit 48cfe8e into development Oct 25, 2026
1 check passed
@pmeems
pmeems deleted the phase-3-backward-compatibility branch October 25, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants