Skip to content

Modern GDAL Integration for MapWinGIS6 - #5

Merged
pmeems merged 2 commits into
developmentfrom
phase-1-generic-algorithm-runner
Oct 23, 2026
Merged

pmeems merged 2 commits into
developmentfrom
phase-1-generic-algorithm-runner

Conversation

@pmeems

@pmeems pmeems commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Adds a generic GDAL algorithm runner using the pinned GDAL 3.12 C++ registry API, with typed arguments, command-line parsing, progress/cancellation, structured diagnostics, finalization, usage JSON, and owned output datasets. The native MapWinGIS.Core.dll API is the available generic façade; a COM façade is deferred because the ActiveX wrapper has not been started. Uses the existing GDAL >=3.12.4 dependency; no dependency changes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Dataset reference handling, pre-execution cancellation, and linker-path quoting need correction before approval.

3 open issues
What changed in this PR

Adds a native GDAL algorithm runner to MapWinGIS.Core using the existing GDAL registry API. The COM façade remains deferred until the ActiveX wrapper is implemented.

Changes:

  • Adds typed and command-line configuration, progress/cancellation, diagnostics, finalization, and output dataset ownership.
  • Integrates the runner into the native libraries and adds execution and raster-conversion tests.
  • Documents the native façade and public dataset ownership API.

Builds and tests were not run in this review environment.

File Description
tests/​MapWinGIS.Core.Tests/​MapWinGIS.Core.Tests.vcxproj Registers the runner tests.
tests/​MapWinGIS.Core.Tests/​GdalAlgorithmRunnerTests.cpp Tests configuration, failures, cancellation, and raster conversion.
src/​MwGdalCore/​MwGdalCore.vcxproj Includes the runner implementation and header.
src/​MwGdalCore/​GdalAlgorithmRunner.cpp Implements algorithm execution and dataset ownership.
src/​MapWinGIS.Core/​MapWinGIS.Core.vcxproj Adds whole-archive linking and the public header.
src/​MapWinGIS.Core/​include/​mapwingis/​gdal/​GdalAlgorithmRunner.h Declares the runner and owned dataset API.
docs/​ARCHITECTURE.md Documents native exposure and GDAL type forward declarations.

Review effort: Balanced

Comment thread src/MwGdalCore/GdalAlgorithmRunner.cpp Resolved
Comment thread src/MwGdalCore/GdalAlgorithmRunner.cpp Resolved
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pmeems
pmeems merged commit 55f5bc2 into development Oct 23, 2026
1 check passed
@pmeems
pmeems deleted the phase-1-generic-algorithm-runner branch October 23, 2026 17:37
@pmeems pmeems mentioned this pull request Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants