Repository navigation
Modern GDAL Integration for MapWinGIS6 - #5
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Dataset reference handling, pre-execution cancellation, and linker-path quoting need correction before approval.
3 open issues
What changed in this PR
Adds a native GDAL algorithm runner to MapWinGIS.Core using the existing GDAL registry API. The COM façade remains deferred until the ActiveX wrapper is implemented.
Changes:
- Adds typed and command-line configuration, progress/cancellation, diagnostics, finalization, and output dataset ownership.
- Integrates the runner into the native libraries and adds execution and raster-conversion tests.
- Documents the native façade and public dataset ownership API.
Builds and tests were not run in this review environment.
| File | Description |
|---|---|
| tests/MapWinGIS.Core.Tests/MapWinGIS.Core.Tests.vcxproj | Registers the runner tests. |
| tests/MapWinGIS.Core.Tests/GdalAlgorithmRunnerTests.cpp | Tests configuration, failures, cancellation, and raster conversion. |
| src/MwGdalCore/MwGdalCore.vcxproj | Includes the runner implementation and header. |
| src/MwGdalCore/GdalAlgorithmRunner.cpp | Implements algorithm execution and dataset ownership. |
| src/MapWinGIS.Core/MapWinGIS.Core.vcxproj | Adds whole-archive linking and the public header. |
| src/MapWinGIS.Core/include/mapwingis/gdal/GdalAlgorithmRunner.h | Declares the runner and owned dataset API. |
| docs/ARCHITECTURE.md | Documents native exposure and GDAL type forward declarations. |
Review effort: Balanced
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Adds a generic GDAL algorithm runner using the pinned GDAL 3.12 C++ registry API, with typed arguments, command-line parsing, progress/cancellation, structured diagnostics, finalization, usage JSON, and owned output datasets. The native MapWinGIS.Core.dll API is the available generic façade; a COM façade is deferred because the ActiveX wrapper has not been started. Uses the existing GDAL >=3.12.4 dependency; no dependency changes.