Repository navigation
Refactor build workflow: - #4
Merged
Merged
Conversation
…and update test result paths
There was a problem hiding this comment.
🟡 Changes recommended
The cache key needs toolchain-aware invalidation so rebuilt dependencies can be saved after hosted-runner compiler updates.
1 open issue
What changed in this PR
Refactors the Windows CI workflow to improve dependency caching and reduce routine build work while retaining full platform/configuration coverage for pushes to main.
Changes:
- Adds cancellation of superseded runs and limits other events to Debug x64.
- Replaces vcpkg’s GitHub cache integration with a file-backed cache managed by
actions/cache. - Makes test exit handling explicit and tightens artifact paths and missing-file behavior.
Builds and tests were not run in this review.
| File | Description |
|---|---|
.github/workflows/build.yml |
Updates concurrency, build matrix, dependency caching, and artifact handling. |
Review effort: Balanced
Co-authored-by: pmeems <12067729+pmeems@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

enhance caching, improve variable handling, and update test result paths