Skip to content

Decompose ActiveX event and rendering components - #33

Merged
pmeems merged 2 commits into
developmentfrom
step5-decompose-activex-layer
Oct 31, 2026
Merged

pmeems merged 2 commits into
developmentfrom
step5-decompose-activex-layer

Conversation

@pmeems

@pmeems pmeems commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Extract ActiveX COM conversion and event delivery from the control, split rendering responsibilities, and move first-layer scene selection into Core. This review update propagates constructor allocation failures, fixes dispatch-window error reporting, copies event arguments per sink, ties scene feature counts to the selected layer, and adds direct COM conversion coverage.

The tests cover string and SAFEARRAY edge cases, first-layer-only scene behavior, corrected renderer checks, and real GDAL progress/completion delivery through the registration-free ActiveX host. No new dependencies.

Validation: Debug x64 build with zero warnings; 170 native tests passed and 3 optional tests were skipped; the host passed all 14 checks.

Limitations: Win32 and Release were not built. A separate fake-sink test for non-IDispatch sinks and reentrant window destruction remains open.

pmeems and others added 2 commits October 31, 2026 00:55
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pmeems pmeems changed the title Resolve the codebase conformance review findings – MapWinGIS6 development Decompose ActiveX event and rendering components Oct 31, 2026
@pmeems
pmeems merged commit 6898688 into development Oct 31, 2026
1 check passed
@pmeems
pmeems deleted the step5-decompose-activex-layer branch October 31, 2026 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant