Repository navigation
Decompose ActiveX event and rendering components - #33
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract ActiveX COM conversion and event delivery from the control, split rendering responsibilities, and move first-layer scene selection into Core. This review update propagates constructor allocation failures, fixes dispatch-window error reporting, copies event arguments per sink, ties scene feature counts to the selected layer, and adds direct COM conversion coverage.
The tests cover string and SAFEARRAY edge cases, first-layer-only scene behavior, corrected renderer checks, and real GDAL progress/completion delivery through the registration-free ActiveX host. No new dependencies.
Validation: Debug x64 build with zero warnings; 170 native tests passed and 3 optional tests were skipped; the host passed all 14 checks.
Limitations: Win32 and Release were not built. A separate fake-sink test for non-IDispatch sinks and reentrant window destruction remains open.