Skip to content

Plan: resolve the codebase conformance review findings – MapWinGIS6 development - #32

Merged
pmeems merged 2 commits into
developmentfrom
step4-split-gdal-public-headers
Oct 30, 2026
Merged

pmeems merged 2 commits into
developmentfrom
step4-split-gdal-public-headers

Conversation

@pmeems

@pmeems pmeems commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Splits the broad GDAL runtime API into focused config, diagnostics, progress, and operation-result headers. The native callback ABI is now internal, adapter/config state uses PImpl, and dataset arguments require a const GdalDatasetPtr reference so ownership is explicit. Core, ActiveX, and tests use the new headers; ARCHITECTURE.md records the boundary. No dependency changes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@Julian-MW Julian-MW left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source review of the GDAL public-header split. Overall the refactor is clean: the native callback ABI is properly hidden behind the internal GdalProgressAdapterAccess friend, the PImpl conversions are correct, the const GdalDatasetPtr& dataset-argument contract is enforced (including the null check with test coverage), and test coverage for progress/cancellation and callback exceptions was preserved after moving tests out of GdalRuntimeTests.cpp. Three minor findings inline: implementation placement for the new GdalOperationResult.h, an unused adapter parameter on GdalProgressAdapterAccess::Function, and a stale doc line on GdalProgressAdapter.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pmeems
pmeems merged commit 60a6413 into development Oct 30, 2026
1 check passed
@pmeems
pmeems deleted the step4-split-gdal-public-headers branch October 30, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants