Repository navigation
Plan: resolve the codebase conformance review findings – MapWinGIS6 development - #32
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Julian-MW
reviewed
Oct 30, 2026
Julian-MW
left a comment
There was a problem hiding this comment.
Source review of the GDAL public-header split. Overall the refactor is clean: the native callback ABI is properly hidden behind the internal GdalProgressAdapterAccess friend, the PImpl conversions are correct, the const GdalDatasetPtr& dataset-argument contract is enforced (including the null check with test coverage), and test coverage for progress/cancellation and callback exceptions was preserved after moving tests out of GdalRuntimeTests.cpp. Three minor findings inline: implementation placement for the new GdalOperationResult.h, an unused adapter parameter on GdalProgressAdapterAccess::Function, and a stale doc line on GdalProgressAdapter.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the broad GDAL runtime API into focused config, diagnostics, progress, and operation-result headers. The native callback ABI is now internal, adapter/config state uses PImpl, and dataset arguments require a const GdalDatasetPtr reference so ownership is explicit. Core, ActiveX, and tests use the new headers; ARCHITECTURE.md records the boundary. No dependency changes.