Skip to content

Modern GDAL Integration for MapWinGIS6 - #3

Merged
pmeems merged 2 commits into
developmentfrom
phase-0-foundation
Oct 23, 2026
Merged

pmeems merged 2 commits into
developmentfrom
phase-0-foundation

Conversation

@pmeems

@pmeems pmeems commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Phase 0 adds the native GDAL runtime foundation as a MwGdalCore static library linked into MapWinGIS.Core. It provides once-only process-lifetime driver registration, scoped configuration restoration, structured error capture, and progress/cancellation adapters while keeping COM concerns out of the core. GDAL remains a vcpkg dependency, constrained to 3.12.4 or later; the pinned baseline resolves 3.12.4.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Scoped configuration restoration can corrupt process-wide settings, and test filename conversions do not reliably preserve non-ASCII Windows paths.

2 open issues
What changed in this PR

Adds the Phase 0 native GDAL runtime foundation as a static library linked into MapWinGIS.Core, keeping COM concerns outside the core.

Changes:

  • Adds once-only driver registration, scoped configuration, structured diagnostics, and progress/cancellation helpers.
  • Integrates the library into the solution and adds runtime tests.
  • Requires GDAL 3.12.4 or later and documents dependency and lifecycle behavior.

Builds and tests were not run.

File Description
vcpkg.json Adds the minimum GDAL version constraint.
tests/​MapWinGIS.Core.Tests/​MapWinGIS.Core.Tests.vcxproj Includes the new runtime tests.
tests/​MapWinGIS.Core.Tests/​GdalRuntimeTests.cpp Tests initialization, configuration, diagnostics, progress, and cancellation.
src/​MwGdalCore/​MwGdalCore.vcxproj Defines the native static library.
src/​MwGdalCore/​GdalRuntime.cpp Implements the runtime helpers.
src/​MapWinGIS.Core/​src/​gdal/​GdalEnvironment.cpp Delegates registration and makes initialization status atomic.
src/​MapWinGIS.Core/​MapWinGIS.Core.vcxproj References the static library and public header.
src/​MapWinGIS.Core/​include/​mapwingis/​gdal/​GdalRuntime.h Declares the runtime helper APIs.
MapWinGIS6.slnx Adds the static library project.
docs/​gdal-version.md Documents the GDAL requirement and registration lifetime.
docs/​ARCHITECTURE.md Describes runtime integration and helper usage.

Review effort: Balanced

Comment thread src/MwGdalCore/GdalRuntime.cpp Resolved
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pmeems
pmeems merged commit c68ed87 into development Oct 23, 2026
1 of 4 checks passed
@pmeems
pmeems deleted the phase-0-foundation branch October 23, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants