Repository navigation
Modern GDAL Integration for MapWinGIS6 - #3
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Scoped configuration restoration can corrupt process-wide settings, and test filename conversions do not reliably preserve non-ASCII Windows paths.
2 open issues
What changed in this PR
Adds the Phase 0 native GDAL runtime foundation as a static library linked into MapWinGIS.Core, keeping COM concerns outside the core.
Changes:
- Adds once-only driver registration, scoped configuration, structured diagnostics, and progress/cancellation helpers.
- Integrates the library into the solution and adds runtime tests.
- Requires GDAL 3.12.4 or later and documents dependency and lifecycle behavior.
Builds and tests were not run.
| File | Description |
|---|---|
vcpkg.json |
Adds the minimum GDAL version constraint. |
tests/MapWinGIS.Core.Tests/MapWinGIS.Core.Tests.vcxproj |
Includes the new runtime tests. |
tests/MapWinGIS.Core.Tests/GdalRuntimeTests.cpp |
Tests initialization, configuration, diagnostics, progress, and cancellation. |
src/MwGdalCore/MwGdalCore.vcxproj |
Defines the native static library. |
src/MwGdalCore/GdalRuntime.cpp |
Implements the runtime helpers. |
src/MapWinGIS.Core/src/gdal/GdalEnvironment.cpp |
Delegates registration and makes initialization status atomic. |
src/MapWinGIS.Core/MapWinGIS.Core.vcxproj |
References the static library and public header. |
src/MapWinGIS.Core/include/mapwingis/gdal/GdalRuntime.h |
Declares the runtime helper APIs. |
MapWinGIS6.slnx |
Adds the static library project. |
docs/gdal-version.md |
Documents the GDAL requirement and registration lifetime. |
docs/ARCHITECTURE.md |
Describes runtime integration and helper usage. |
Review effort: Balanced
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Phase 0 adds the native GDAL runtime foundation as a MwGdalCore static library linked into MapWinGIS.Core. It provides once-only process-lifetime driver registration, scoped configuration restoration, structured error capture, and progress/cancellation adapters while keeping COM concerns out of the core. GDAL remains a vcpkg dependency, constrained to 3.12.4 or later; the pinned baseline resolves 3.12.4.