Repository navigation
Merge conflicts - #21
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Scaled draw targets can be only partially covered by an unscaled bitmap, while some initialization failures retain generic diagnostics and context-failure recovery lacks deterministic regression coverage.
No open issues 🎉
What changed in this PR
Adds OpenGL rendering with GDI fallback to the ActiveX layer while keeping Core rendering data independent of graphics APIs.
Changes:
- Introduces backend selection, rendering diagnostics, target limits, and context recovery.
- Exposes rendering preferences through a derived COM interface and adds renderer and host checks.
- Avoids forced feature counting during indexing and updates architecture guidance and development tooling.
Builds and tests were not run during this review.
| File | Description |
|---|---|
| tests/MapWinGIS.Core.Tests/VectorLayerRendererTests.cpp | Adds rendering, fallback, geometry-validation, and target-limit tests. |
| tests/MapWinGIS.Core.Tests/MapWinGIS.Core.Tests.vcxproj | Includes renderer sources and tests. |
| tests/MapWinGIS.Core.Tests/ActiveXActivationTests.cpp | Checks original and extended COM interfaces and rendering properties. |
| src/MapWinGIS.Core/src/vector/VectorDataset.cpp | Avoids forced feature counting before indexing. |
| src/MapWinGIS.ActiveX/VectorRenderBackend.h | Defines the internal rendering backend contract. |
| src/MapWinGIS.ActiveX/VectorLayerRenderer.h | Declares backend preferences and diagnostics. |
| src/MapWinGIS.ActiveX/VectorLayerRenderer.cpp | Coordinates OpenGL rendering and GDI fallback. |
| src/MapWinGIS.ActiveX/OpenGlVectorLayerRenderer.h | Declares OpenGL resources and target-limit checks. |
| src/MapWinGIS.ActiveX/OpenGlVectorLayerRenderer.cpp | Implements framebuffer rendering, readback, limits, and recovery. |
| src/MapWinGIS.ActiveX/MapWinGISControl.h | Adds the extended COM interface and renderer ownership. |
| src/MapWinGIS.ActiveX/MapWinGISControl.cpp | Implements rendering properties and delegates drawing. |
| src/MapWinGIS.ActiveX/MapWinGIS.ActiveX.vcxproj | Registers new backend sources and headers. |
| src/MapWinGIS.ActiveX/MapWinGIS.ActiveX.idl | Adds rendering automation through IMapWinGISControl2. |
| src/MapWinGIS.ActiveX/GdiVectorLayerRenderer.h | Declares the GDI fallback backend. |
| src/MapWinGIS.ActiveX/GdiVectorLayerRenderer.cpp | Extracts GDI drawing and adds coordinate validation. |
| samples/CSharp/ActiveXTestHost/MainForm.cs | Displays rendering status and checks GDI selection. |
| README.md | Updates ActiveX status and compatibility goals. |
| msbuild-extractor.json | Configures compilation-database generation. |
| docs/TESTING.md | Documents renderer validation and interactive-host limitations. |
| docs/PORTING.md | Clarifies selective compatibility and modernization priorities. |
| docs/ARCHITECTURE.md | Describes backend responsibilities and rendering policies. |
| AGENTS.md | Updates project status and development priorities. |
| .gitignore | Excludes generated compilation-database output. |
| .github/copilot-instructions.md | Aligns guidance with implemented ActiveX support and modernization goals. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.