Skip to content

Review guardrails and avoid redundant vector feature scan - #18

Merged
pmeems merged 8 commits into
developmentfrom
review/guardrails-and-vector-index-scan
Oct 26, 2026
Merged

pmeems merged 8 commits into
developmentfrom
review/guardrails-and-vector-index-scan

Conversation

@pmeems

@pmeems pmeems commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

This review pass found a redundant forced feature-count operation in the lazy feature-ID index, stale documentation about the ActiveX implementation, and guardrails that over-prioritized legacy parity.

Code improvement

  • Avoid calling GetFeatureCount(TRUE) before scanning all feature IDs. For drivers without a fast count, that can force an extra full-layer pass before the index-building pass. Use the non-forcing count only as an optional reserve hint.

Guardrails and documentation

  • Update AGENTS.md to make the priority explicit: optimize the v6 structure and API first; preserve compatibility second, where it fits without undue complexity or blocking improvements.
  • Align docs/PORTING.md, docs/ARCHITECTURE.md, README.md, and .github/copilot-instructions.md with the same principle.
  • Clarify that the ActiveX control has an initial implementation and that broader MapWinGIS 5 API compatibility remains incremental and selective.

Validation

  • Retrieved and reviewed files from the current development branch and updated the PR branch.
  • The required Windows Debug/x64 build and GoogleTest suite could not be run in this environment; CI should validate the code change.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The localized optimization preserves feature-ID scanning behavior, and static review found no blocking issues; Windows build and test validation remain pending.

No open issues 🎉

What changed in this PR

This PR removes a potentially redundant vector-layer scan and aligns project guidance around modern v6 design with selective legacy compatibility.

Changes:

  • Use a non-forcing feature count as an optional allocation hint when building the feature-ID index.
  • Prioritize maintainable v6 architecture while documenting deliberate compatibility differences.
  • Correct outdated descriptions of the initial ActiveX implementation.

Windows Debug/x64 build and GoogleTest validation remain pending.

File Description
src/​MapWinGIS.Core/​src/​vector/​VectorDataset.cpp Avoids forcing a feature count before scanning IDs.
README.md Updates compatibility goals and ActiveX status.
docs/​PORTING.md Defines deliberate, selective compatibility decisions.
docs/​ARCHITECTURE.md Clarifies v6 design priorities and COM compatibility boundaries.
AGENTS.md Updates development priorities and implementation status.
.github/​copilot-instructions.md Aligns coding guidance with the revised design priorities.

Review effort: Balanced

@pmeems
pmeems merged commit 07c2bb3 into development Oct 26, 2026
2 checks passed
@pmeems
pmeems deleted the review/guardrails-and-vector-index-scan branch October 26, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants