Repository navigation
Review guardrails and avoid redundant vector feature scan - #18
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The localized optimization preserves feature-ID scanning behavior, and static review found no blocking issues; Windows build and test validation remain pending.
No open issues 🎉
What changed in this PR
This PR removes a potentially redundant vector-layer scan and aligns project guidance around modern v6 design with selective legacy compatibility.
Changes:
- Use a non-forcing feature count as an optional allocation hint when building the feature-ID index.
- Prioritize maintainable v6 architecture while documenting deliberate compatibility differences.
- Correct outdated descriptions of the initial ActiveX implementation.
Windows Debug/x64 build and GoogleTest validation remain pending.
| File | Description |
|---|---|
src/MapWinGIS.Core/src/vector/VectorDataset.cpp |
Avoids forcing a feature count before scanning IDs. |
README.md |
Updates compatibility goals and ActiveX status. |
docs/PORTING.md |
Defines deliberate, selective compatibility decisions. |
docs/ARCHITECTURE.md |
Clarifies v6 design priorities and COM compatibility boundaries. |
AGENTS.md |
Updates development priorities and implementation status. |
.github/copilot-instructions.md |
Aligns coding guidance with the revised design priorities. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This review pass found a redundant forced feature-count operation in the lazy feature-ID index, stale documentation about the ActiveX implementation, and guardrails that over-prioritized legacy parity.
Code improvement
GetFeatureCount(TRUE)before scanning all feature IDs. For drivers without a fast count, that can force an extra full-layer pass before the index-building pass. Use the non-forcing count only as an optional reserve hint.Guardrails and documentation
AGENTS.mdto make the priority explicit: optimize the v6 structure and API first; preserve compatibility second, where it fits without undue complexity or blocking improvements.docs/PORTING.md,docs/ARCHITECTURE.md,README.md, and.github/copilot-instructions.mdwith the same principle.Validation
developmentbranch and updated the PR branch.