Repository navigation
MapWinGIS6 ActiveX Control and Modern Rendering Architecture - #17
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Valid dimensional polygon layers are rejected, and per-ring buffer reservation introduces quadratic repaint work for polygons with many holes.
2 open issues
What changed in this PR
Adds the first visible vector-map path: Core prepares owned polygon scene data, and the ActiveX control renders it with GDI using existing GDAL dependencies.
Changes:
- Adds polygon scene extraction and native tests.
- Exposes vector loading and layer state through ActiveX automation.
- Extends the C# host to verify rendered pixels and documents current rendering limits.
Builds and tests were not rerun during this review.
| File | Description |
|---|---|
tests/MapWinGIS.Core.Tests/VectorRenderSceneTests.cpp |
Tests polygon coordinates and extents. |
tests/MapWinGIS.Core.Tests/MapWinGIS.Core.Tests.vcxproj |
Includes scene tests. |
src/MapWinGIS.Core/src/rendering/VectorRenderScene.cpp |
Extracts owned polygon scene data. |
src/MapWinGIS.Core/MapWinGIS.Core.vcxproj |
Includes the scene implementation and header. |
src/MapWinGIS.Core/include/mapwingis/rendering/VectorRenderScene.h |
Defines the backend-neutral scene API. |
src/MapWinGIS.ActiveX/VectorLayerRenderer.h |
Declares the GDI rendering entry point. |
src/MapWinGIS.ActiveX/VectorLayerRenderer.cpp |
Fits and paints polygon scenes. |
src/MapWinGIS.ActiveX/MapWinGISControl.h |
Declares loading methods and scene state. |
src/MapWinGIS.ActiveX/MapWinGISControl.cpp |
Loads datasets and integrates scene painting. |
src/MapWinGIS.ActiveX/MapWinGIS.ActiveX.vcxproj |
Includes the GDI renderer. |
src/MapWinGIS.ActiveX/MapWinGIS.ActiveX.idl |
Exposes loading and layer-state automation. |
samples/CSharp/ActiveXTestHost/MainForm.cs |
Generates GeoJSON and checks rendered pixels. |
docs/TESTING.md |
Documents rendering checks and reported validation. |
docs/BUILDING.md |
Updates host validation instructions. |
docs/ARCHITECTURE.md |
Describes scene ownership and the initial GDI path. |
Review effort: Balanced
pmeems
left a comment
There was a problem hiding this comment.
I reviewed the changed code paths and the existing inline review threads. I did not add duplicate inline comments: the two concrete issues I could verify are already covered by the existing comments on dimensional polygon layer type checking and per-ring point-buffer reservation. The reported build/test results were not independently rerun as part of this review.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Adds the first visible-map milestone by loading a real vector layer through MapWinGIS.Core and painting it in the ActiveX control.
Core prepares owned Polygon/MultiPolygon scene data; the OCX uses a small GDI painter, and the .NET host verifies actual rendered pixels from a generated GeoJSON fixture. This reuses the existing GDAL/OGR dependency and adds no packages.
Validation: Debug x64 solution build; 135 native tests passed and 2 skipped; all 12 registration-free host checks passed. Current limits: first polygon layer only, source coordinates without reprojection, and no interchangeable backend, OpenGL, or CPU fallback policy yet. Host integration requires an interactive desktop.