Repository navigation
MapWinGIS6 ActiveX Control and Modern Rendering Architecture - #15
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The hosting test needs control-level assertions to detect failures in resize-driven repainting rather than checking only host-window state.
1 open issue
What changed in this PR
This PR establishes the initial ActiveX hosting and drawing lifecycle, keeping window behavior in the OCX while leaving map rendering and backend implementation for later phases.
Changes:
- Adds resize-triggered view invalidation and opaque background drawing.
- Adds drawing assertions and a registered host lifecycle test, invoked by the activation script.
- Updates documentation to distinguish implemented hosting behavior from planned rendering capabilities.
Builds and tests were not independently run.
| File | Description |
|---|---|
| tests/MapWinGIS.Core.Tests/Verify-ActiveXActivation.ps1 | Runs the registered hosting test and restores its environment setting. |
| tests/MapWinGIS.Core.Tests/ActiveXActivationTests.cpp | Adds drawing checks and host resize, repaint, destruction, and recreation coverage. |
| src/MapWinGIS.ActiveX/MapWinGISControl.h | Declares resize and drawing handlers and opaque view status. |
| src/MapWinGIS.ActiveX/MapWinGISControl.cpp | Implements resize invalidation and background painting. |
| docs/BUILDING.md | Documents the expanded activation verification. |
| docs/ARCHITECTURE.md | Clarifies implemented lifecycle behavior and deferred rendering work. |
Review effort: Balanced
pmeems
left a comment
There was a problem hiding this comment.
I reviewed the source diff and the existing inline review thread. I did not identify another distinct, actionable source issue beyond the existing finding about verifying the hosted control's bounds, painting, and resize-driven invalidation. I have therefore not added duplicate inline comments.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Motivation: establish the first hostable ActiveX lifecycle before map rendering work begins.
Design: keep hosting and window behavior in the OCX; invalidate through ATL on resize and paint an opaque client area. Add deterministic drawing coverage and a registered OLE host test for resize, repaint, destruction, and recreation.
Dependencies: none added; ATL is already configured. Real map rendering and CPU/OpenGL backends remain later phases.
Validation: Debug x64 solution build; 133 unit tests passed and 2 skipped. The registered host-lifecycle integration test passed.