Repository navigation
Modern GDAL Integration for MapWinGIS6 - #14
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The focused documentation, sample, and test changes align with existing contracts and build conventions, with no unresolved blocking issues.
No open issues 🎉
What changed in this PR
Completes Phase 6 of GDAL integration with user-facing documentation, a buildable native C++ sample, and regression coverage for unavailable output drivers.
Changes:
- Documents GDAL setup, APIs, cancellation, pipelines, cloud paths, migration, and limitations.
- Adds a raster-to-GeoTIFF sample to the solution.
- Tests unavailable-driver failures and documents opt-in network testing.
The PR reports a successful Debug | x64 build and 133 passing tests; builds and tests were not rerun during this review.
| File | Description |
|---|---|
tests/MapWinGIS.Core.Tests/GdalTypedOptionsTests.cpp |
Adds unavailable-output-driver regression coverage. |
samples/Cpp/Translate.vcxproj |
Defines the native sample project linked to Core. |
samples/Cpp/translate.cpp |
Demonstrates typed raster conversion and error reporting. |
README.md |
Links the integration guide and identifies native samples. |
MapWinGIS6.slnx |
Includes the sample project in the solution. |
docs/TESTING.md |
Documents the opt-in network-test setting. |
docs/gdal-integration.md |
Adds the GDAL integration and troubleshooting guide. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes Phase 6 by adding user-facing GDAL integration documentation, a buildable C++ translation sample, and coverage for unavailable output drivers. The guide documents architecture, initialization and dependencies, typed and generic APIs, progress/cancellation, in-memory pipelines, cloud paths, GDAL 3 axis order, migration, and limitations. Algorithm details remain sourced from GDAL
UsageAsJson()rather than duplicated option lists.Fixtures stay runtime-generated in temporary directories; the repository's test conventions prohibit committing generated shapefiles/databases. No C# sample is included because the native Core has no managed binding and the ActiveX layer does not expose GDAL yet.
Validation: Debug | x64 solution build succeeded with no new Level 4 warnings; 133 tests passed and the opt-in network test was skipped. The C++ sample built and its argument-validation path was smoke-tested. GDAL 3.12.4+ and existing vcpkg dependencies are required; no dependency manifests changed.