Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The COM interface map omits IPersist, and the activation check can destroy an existing per-user registration.
2 open issues
What changed in this PR
Establishes the initial ActiveX COM boundary around MapWinGIS.Core, while deferring host lifecycle, rendering, and painting.
Changes:
- Adds a statically linked ATL control with new COM identifiers and a
CoreInitializedautomation property. - Implements COM server exports and per-user registration.
- Integrates the control into the solution and adds activation checks and build documentation.
| File | Description |
|---|---|
| tests/MapWinGIS.Core.Tests/Verify-ActiveXActivation.ps1 | Checks registered COM activation and automation access. |
| tests/MapWinGIS.Core.Tests/MapWinGIS.Core.Tests.vcxproj | Adds activation tests and the ActiveX build dependency. |
| tests/MapWinGIS.Core.Tests/ActiveXActivationTests.cpp | Tests class-factory activation and core-state access. |
| src/MapWinGIS.ActiveX/resource.h | Defines the registration resource identifier. |
| src/MapWinGIS.ActiveX/MapWinGISControl.rgs | Defines CLSID, ProgID, and server registration. |
| src/MapWinGIS.ActiveX/MapWinGISControl.h | Declares the ATL control and COM interface map. |
| src/MapWinGIS.ActiveX/MapWinGISControl.cpp | Implements the core-state automation property. |
| src/MapWinGIS.ActiveX/MapWinGIS.ActiveX.vcxproj | Configures OCX compilation, static ATL, and Core linkage. |
| src/MapWinGIS.ActiveX/MapWinGIS.ActiveX.rc | Embeds registration and type-library resources. |
| src/MapWinGIS.ActiveX/MapWinGIS.ActiveX.idl | Defines the automation interface and COM identifiers. |
| src/MapWinGIS.ActiveX/MapWinGIS.ActiveX.def | Exports COM server entry points. |
| src/MapWinGIS.ActiveX/ActiveXModule.h | Declares the ATL DLL module. |
| src/MapWinGIS.ActiveX/ActiveXModule.cpp | Implements activation and registration entry points. |
| MapWinGIS6.slnx | Includes the ActiveX project. |
| docs/BUILDING.md | Documents ATL requirements and activation verification. |
Review effort: Balanced
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…tivex-project-and-establish-com-activation
pmeems
commented
Oct 25, 2026
pmeems
left a comment
Contributor
Author
There was a problem hiding this comment.
Review focused on the ActiveX/COM boundary and activation behavior. I found one additional issue to address before this control is hosted in an OLE container.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
pmeems
deleted the
phase-2-add-activex-project-and-establish-com-activation
branch
October 25, 2026 20:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Motivation: establish the ActiveX COM boundary before implementing host lifecycle and rendering.
Adds a minimal ATL in-process control with new COM identifiers, a CoreInitialized automation property backed by MapWinGIS.Core, and per-user registration. ATL is statically linked; the OCX keeps Core as its runtime dependency. Rendering and painting remain deferred to later phases.
Validation: Debug x64 solution build, all 115 runnable GoogleTests, and the per-user COM activation check. One network-dependent test was skipped.