Repository navigation
Keep GDAL diagnostics suppressed during feature ID scans - #1
Merged
Merged
Conversation
pmeems
marked this pull request as ready for review
October 23, 2026 09:21
pmeems
added a commit
that referenced
this pull request
Oct 23, 2026
* Initialize MapWinGIS 6 repository Add the initial solution, build, CI, vcpkg, and bootstrap layout; introduce the first MapWinGIS.Core.dll slice with GDAL/OGR initialization, error handling, geometry extents, and vector dataset/layer access; add GoogleTest-based tests and reference data; and refresh vendored headers, libraries, and runtime deployment for GDAL, GEOS, PROJ, SQLite, curl, OpenSSL, and related dependencies. * Add documentation for agents, architecture, coding standards, porting guidelines, and testing procedures * Fix LICENSE: MIT -> MPL-2.0 to match README and CODING-STANDARDS Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Remove vcpkg_installed folder from repository. * Align test layout with TESTING.md conventions Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add vcpkg installed libraries to .gitignore * Update README project status Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Enhance development guidelines, update build workflow, and improve error handling - Expanded development guidelines in copilot-instructions.md for clarity on C++20 usage and project context. - Updated build.yml to include the 'development' branch for CI workflows. - Improved error handling in core classes by adding CoreError exceptions for out-of-range feature access in VectorDataset and VectorLayer. - Added tests for error handling in GdalEnvironment and VectorLayer to ensure robustness against invalid feature indexes and flush failures. * Keep GDAL quiet scope active during feature ID scan (#1) --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GdalEnvironment::QuietScopealive for the complete lazy feature-ID scan inVectorLayer::Impl::EnsureFeatureIds().IgnoreAllButIdsconstruction; previously it ended immediately afterSetIgnoredFields, so diagnostics duringGetNextFeature()could leak to the configured GDAL error/log handler despite the architecture and testing guidance.Validation
AGENTS.mdand its referenceddocs/BUILDING.md,docs/ARCHITECTURE.md,docs/CODING-STANDARDS.md,docs/PORTING.md, anddocs/TESTING.md.Debug | x64build and test executable.