Skip to content

Keep GDAL diagnostics suppressed during feature ID scans - #1

Merged
pmeems merged 1 commit into
developmentfrom
fix/vector-id-scan-quiet-scope
Oct 23, 2026
Merged

pmeems merged 1 commit into
developmentfrom
fix/vector-id-scan-quiet-scope

Conversation

@pmeems

@pmeems pmeems commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Keep GdalEnvironment::QuietScope alive for the complete lazy feature-ID scan in VectorLayer::Impl::EnsureFeatureIds().
  • Remove the too-short-lived scope from IgnoreAllButIds construction; previously it ended immediately after SetIgnoredFields, so diagnostics during GetNextFeature() could leak to the configured GDAL error/log handler despite the architecture and testing guidance.

Validation

  • Reviewed AGENTS.md and its referenced docs/BUILDING.md, docs/ARCHITECTURE.md, docs/CODING-STANDARDS.md, docs/PORTING.md, and docs/TESTING.md.
  • Inspected the relevant implementation and tests.
  • Could not run the Windows MSBuild/GoogleTest commands in this environment; please validate with the documented Debug | x64 build and test executable.

@pmeems
pmeems marked this pull request as ready for review October 23, 2026 09:21
@pmeems
pmeems merged commit 7f12016 into development Oct 23, 2026
4 checks passed
pmeems added a commit that referenced this pull request Oct 23, 2026
* Initialize MapWinGIS 6 repository

Add the initial solution, build, CI, vcpkg, and bootstrap layout; introduce the first MapWinGIS.Core.dll slice with GDAL/OGR initialization, error handling, geometry extents, and vector dataset/layer access; add GoogleTest-based tests and reference data; and refresh vendored headers, libraries, and runtime deployment for GDAL, GEOS, PROJ, SQLite, curl, OpenSSL, and related dependencies.

* Add documentation for agents, architecture, coding standards, porting guidelines, and testing procedures

* Fix LICENSE: MIT -> MPL-2.0 to match README and CODING-STANDARDS

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Remove vcpkg_installed folder from repository.

* Align test layout with TESTING.md conventions

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Add vcpkg installed libraries to .gitignore

* Update README project status

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Enhance development guidelines, update build workflow, and improve error handling

- Expanded development guidelines in copilot-instructions.md for clarity on C++20 usage and project context.
- Updated build.yml to include the 'development' branch for CI workflows.
- Improved error handling in core classes by adding CoreError exceptions for out-of-range feature access in VectorDataset and VectorLayer.
- Added tests for error handling in GdalEnvironment and VectorLayer to ensure robustness against invalid feature indexes and flush failures.

* Keep GDAL quiet scope active during feature ID scan (#1)

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pmeems
pmeems deleted the fix/vector-id-scan-quiet-scope branch October 23, 2026 17:37
@pmeems pmeems mentioned this pull request Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant