Repository navigation
feat: make compatibility mode a setting that follows the Agents using it - #269
Open
yujiezhang-ops wants to merge 1 commit into
Open
yujiezhang-ops wants to merge 1 commit into
yujiezhang-ops wants to merge 1 commit into
Conversation
Compatibility mode is an implementation detail of one Agent using one model service, so it no longer has a page or a sidebar entry of its own. - It is still switched on where an Agent needs it: the setup wizard, an Agent's Profile list, a failed model check. The question about starting with the system moves there from the removed page, asked once per session. - It ends on the Agent too. Applying an ordinary Profile drops that Agent's route, and the adapter stops when the last Agent has left (SettleConversion). - Settings holds what is left to set by hand: one switch that names the Agents depending on it, and a fold with the listen address, local keys and model aliases. /conversion redirects there. Fixes found while testing the current release against its real backend: - A route left behind by an Agent that had moved on failed every later save once its Profile was deleted, so compatibility mode could not be stopped, no other Agent could be switched to it and its keys could not be regenerated. A save no longer checks other Agents' routes; a route is checked when it is set, and a request through a dead one is refused on its own. - A Profile that compatibility mode forwards to can no longer be changed to another API type, which made every request of the Agents behind it fail with 401. Deleting it was already refused. - Settings that keep the listen address are swapped in place instead of restarting the listener, which waited five seconds on any answer still streaming and then failed the change. A stop or a move to another address now closes open responses after that grace period instead of failing, and a rollback no longer stops a running adapter first. - The new-Profile form on an Agent page could preselect the adapter's own Provider, which the picker hides, and save a Profile bound to it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compatibility mode is an implementation detail of one Agent using one model service, so it no longer has a page or a sidebar entry of its own.
SettleConversion)./conversionredirects there.Fixes
Found by running the current release's real backend against state written by v0.9.0.
Behaviour to be aware of
Test plan
go test -race ./...,go vet,staticcheckpnpm run buildscripts/check-docs.pyand the third-party licence check🤖 Generated with Claude Code