You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Further issues with new major/minor/fix level parsing #256
Did you install asyncpg with pip?: No (package repository)
In Issue #250 was a fix for Debian branding in version 10.1
But I think it has slight issues and there are more issues with 10.1, not related to the branding but the change of major/minor/fixed version handling.
First of all for the change in #251 : ("PostgreSQL 10.1 (Debian 10.1-3)", (10, 1, 0, 'final', 0),),
I ran into a test fail with this: E AssertionError: (10, 0, 1, 'final', 0) != ServerVersion(major=10, minor=1, micro=0, releaselevel='final', serial=0)
Following the argument in the comment above the code I think it should instead be: ("PostgreSQL 10.1 (Debian 10.1-3)", (10, 0, 1, 'final', 0),),
Further on I ran into a fail with async def test_server_version_01:
Again - broken due to Postgresql 10's second number means micro.
That means 10.1 now is: SELECT current_setting('server_version_num'); => 100001
While 9.5.6 for example was 90506 asyncpg/connection.py:161 get_server_version already does it right, as postgres is doing the mapping.
But test_server_version_01 needs to learn the changed behavior.
Hmm I checked latest head if the code looks the same way, maybe it was just fixed in a different place.
... checking the commit ... @vitaly-burovoy you are right, that looks good - Thanks!
I'll replace my changes with this (on top of 0.13) and test again.
Activity
vitaly-burovoy commentedon Feb 6, 2018
Your reported version is 0.13.0, but a fix is present for 0.14.0 by the commit:
1fa12fe
cpaelzer commentedon Feb 6, 2018
Hmm I checked latest head if the code looks the same way, maybe it was just fixed in a different place.
... checking the commit ...
@vitaly-burovoy you are right, that looks good - Thanks!
I'll replace my changes with this (on top of 0.13) and test again.