Repository navigation
RSK-53: Complete US-02 risk rule management and historyRsk 53 fix us 02 - #18
Merged
Merged
Conversation
…nvironment has been resolved.
AliJohari05
requested review from
Abolfazl-Tajik and
MParsa-ES
as code owners
November 6, 2026 18:26
MParsa-ES
reviewed
Nov 7, 2026
MParsa-ES
reviewed
Nov 7, 2026
MParsa-ES
reviewed
Nov 7, 2026
MParsa-ES
previously approved these changes
Nov 7, 2026
MParsa-ES
left a comment
Owner
There was a problem hiding this comment.
Overall a good addition of the rules to the project but please review the comments I've put and solve them
Abolfazl-Tajik
approved these changes
Nov 7, 2026
MParsa-ES
approved these changes
Nov 7, 2026
MParsa-ES
left a comment
Owner
There was a problem hiding this comment.
Thanks for fixing the problems I mentioned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
تغییرات
نتیجه بررسیها
محدودیت شناختهشده
تغییر مستقیم RiskRule با ORM یا SQL میتواند مسیر سرویس و ثبت تاریخچه را دور بزند. برای محیط عملیاتی، محدودسازی نقشهای دیتابیس و محافظت از مسیر نوشتن نیازمند تصمیم تیم است.