Repository navigation
Record the CCITT a0 fix in the ADR - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs only. ADR-005 now records the exact fix for the Group 4 fixture's twelfth line:
b1must be measured from the last changing element (a0) and searched strictly greater thana0, not>= position. After a vertical or horizontal mode the last transition is the new position, so>= positionselects the transition the decoder just consumed.FFEF) has transitions[0, 11, 12, 16], the decoder reaches position 12 with white, andb1 = 12makes the stream's0000010(V-3) resolve to 9, left of the position. Witha0tracked, line 12'sb1is 16, V-3 resolves to 13, and the line completes.No production code changed; the CCITT decoder is still the next slice, and this makes the fixture + the rule enough to finish it.