Skip to content

Clean up compiler warnings that don't involve concurrency #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ps2 merged 1 commit into from
Oct 12, 2026
Merged

Clean up compiler warnings that don't involve concurrency #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TidepoolServiceKit/Extensions/TDatum.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ extension TDatum {
}
}

extension TDatum: CustomDebugStringConvertible {
extension TDatum: @retroactive CustomDebugStringConvertible {
public var debugDescription: String {
guard let data = try? encoder.encode(self) else {
return "error: failure to encode datum as data"
Expand Down
10 changes: 5 additions & 5 deletions TidepoolServiceKitUI/TidepoolService+UI.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,16 @@ extension TidepoolService: @retroactive ServiceUI {

let settingsView = await SettingsView(service: service, login: { environment in

guard let window = await navController.view.window else {
guard let window = navController.view.window else {
throw TidepoolServiceError.missingWindow
}

let windowContextProvider = await WindowContextProvider(window: window)
let windowContextProvider = WindowContextProvider(window: window)
let sessionProvider = await ASWebAuthenticationSessionProvider(contextProviding: windowContextProvider)
let auth = OAuth2Authenticator(api: service.tapi, environment: environment, sessionProvider: sessionProvider)
try await auth.login()
try await service.completeCreate()
await navController.notifyServiceCreatedAndOnboarded(service)
navController.notifyServiceCreatedAndOnboarded(service)
}, dismiss: {
Task {
await navController.notifyComplete()
Expand All @@ -79,11 +79,11 @@ extension TidepoolService: @retroactive ServiceUI {
Task {
let settingsView = await SettingsView(service: self, login: { [weak self] environment in
if let self {
guard let window = await navController.view.window else {
guard let window = navController.view.window else {
throw TidepoolServiceError.missingWindow
}

let windowContextProvider = await WindowContextProvider(window: window)
let windowContextProvider = WindowContextProvider(window: window)
let sessionProvider = await ASWebAuthenticationSessionProvider(contextProviding: windowContextProvider)
let auth = OAuth2Authenticator(api: self.tapi, environment: environment, sessionProvider: sessionProvider)
try await auth.login()
Expand Down