Repository navigation
Put the report name in the subject when sharing the diagnostic report (next-dev) - #46
Merged
Merged
Conversation
Sharing passed only the file URL, so Mail left the subject blank. The old issue report shared through an activity item source that supplied the report name as the subject; do the same here. (cherry picked from commit 36e436d)
Test✅ successful test Configurationstart with next-dev branch, commit Test DetailsBuild onto SE 3rd gen phone running iOS 27.0.1
|
marionbarker
approved these changes
Oct 24, 2026
marionbarker
left a comment
marionbarker
left a comment
There was a problem hiding this comment.
approve by code review and test.
Thanks much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same change as #45, cherry-picked to next-dev.
Sharing the diagnostic report by email left the subject blank. The old issue report put the report name in the subject, for example "Loop Report 2026-10-23 19:37:00-05:00.md", which made reports easy to tell apart.
The old share (LoopKitUI's
CommandResponseViewController) passed aUIActivityItemSourcethat returned the report name fromsubjectForActivityType. When sharing moved here (#39),DiagnosticReportViewstarted passing the bare file URL, so Mail gets no subject. This adds an item source that supplies the same name as the subject.Testing: built with Xcode 27.1 and checked in the iPhone 17 simulator that the share sheet still offers the report file. The simulator has no Mail app, so the subject line itself still needs checking on a device.