Repository navigation
Default usage data sharing to Share Version Only - #33
Merged
Merged
Conversation
If the preference has never been set, store Share Version Only on first use instead of treating it as no sharing. Onboarding showed that option checked, but the preference was only saved when the selection changed, so tapping Continue without touching it saved nothing. Continue now saves the displayed choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
com.loopkit.Loop.UsageDataPrivacyPreferencehas never been set,LoopKitAnalyticsstores Share Version Only the first time it starts. Before this change, an unset preference meant nothing was sent, and Settings showed No Sharing. This covers installs that skipped onboarding or predate the preference.onChange. Tapping Continue without touching an option therefore saved nothing. Continue now saves whatever choice is displayed.Existing explicit choices, including No Sharing, are unchanged.
Tested by building the LoopWorkspace scheme for the simulator. The onboarding flow and Settings were not exercised.