You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I came around in our discussion. I think pumpID is the only thing required here. Is that already covered then as far as this ticket goes. There is still work in NightscoutUploadKit, to add pumpID.
For pump events / treatments, we don't need a 'device ID'. But as we discussed, tracking the pump that an event came from could be a very useful thing. I'd like to add this, even though it doesn't exist now.
The pumpID in PumpStatus struct is to know which pump the battery/res/etc was reported for, when doing devicestatus uploads. This is not currently tracked either, but I'd like to add it.
The device id for devicestatus entries is discussed here: LoopKit/Loop#98
Activity
ps2 commentedon Aug 2, 2016
I came around in our discussion. I think pumpID is the only thing required here. Is that already covered then as far as this ticket goes. There is still work in NightscoutUploadKit, to add pumpID.
loudnate commentedon Aug 2, 2016
I see pumpID in the device status uploading PR. So what should we use for the device ID? Or is that something you plan to remove?
ps2 commentedon Aug 2, 2016
For pump events / treatments, we don't need a 'device ID'. But as we discussed, tracking the pump that an event came from could be a very useful thing. I'd like to add this, even though it doesn't exist now.
The pumpID in PumpStatus struct is to know which pump the battery/res/etc was reported for, when doing devicestatus uploads. This is not currently tracked either, but I'd like to add it.
The device id for devicestatus entries is discussed here: LoopKit/Loop#98
[-]Persist descriptive device identifier in PumpEvent object[/-][+]Store RileyLink Device ID in PumpEvent object[/+]Changing up the pump event storage and delegate API
Changing up the pump event storage and delegate API (#50)
loudnate commentedon Aug 3, 2016
There was some confusion here on my part; it sounds like we don't need to store deviceID for nightscout.
Removing deviceID from the PumpEvent model
Removing deviceID from the PumpEvent model (#53)